delta/node-new.git/benchmark/napi, branch try_Python3_on_macOS

tools: enable block-scoped-var eslint rule

2019-05-10T14:58:49+00:00

PR-URL: https://github.com/nodejs/node/pull/27616
Reviewed-By: Rich Trott 
Reviewed-By: Anna Henningsen 
Reviewed-By: Luigi Pinca 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Trivikram Kamat

doc,lib,test: capitalize comment sentences

2018-12-17T16:14:35+00:00

This activates the eslint capitalize comment rule for comments
above 50 characters.

PR-URL: https://github.com/nodejs/node/pull/24996
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Anna Henningsen 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: James M Snell

tools: capitalize sentences

2018-12-10T16:07:18+00:00

This adds the `capitalized-comments` eslint rule to verify that
actual sentences use capital letters as starting letters. It ignores
special words and all lines below 62 characters.

PR-URL: https://github.com/nodejs/node/pull/24808
Reviewed-By: Sam Ruby 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Sakthipriyan Vairamani

build: use BUILDTYPE in bench-addons-build targets

2018-11-11T17:09:25+00:00

This commit uses the BUILDTYPE for the benchmark targets that currently
explicitly use Release as the build type.

The motivation for this change is allows switching between debug builds
and release builds using the bench-addons-clean/bench-addons-build
targets.

PR-URL: https://github.com/nodejs/node/pull/24033
Reviewed-By: Richard Lau 
Reviewed-By: Refael Ackermann 
Reviewed-By: James M Snell

test: fix v8 Set/Get compiler warnings

2018-11-11T07:02:30+00:00

PR-URL: https://github.com/nodejs/node/pull/24246
Reviewed-By: Anna Henningsen 
Reviewed-By: Refael Ackermann

benchmark: remove unused catch bindings

2018-11-06T15:59:23+00:00

PR-URL: https://github.com/nodejs/node/pull/24079
Reviewed-By: Sam Roberts 
Reviewed-By: Wyatt Preul

test: add test-benchmark-napi

2018-10-24T13:58:19+00:00

Also makes sure that the napi benchmark is built before running jstest.

Skipped on windows since n-api benchmarks aren't built there yet.

PR-URL: https://github.com/nodejs/node/pull/23585
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Denys Otrishko 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Sakthipriyan Vairamani

benchmark: increase lint compliance

2018-10-07T23:58:45+00:00

Remove two eslint-disable comments by replacing string concatenation
with template literals. These changes are in catch blocks that are not
part of the actual code being benchmarked.

PR-URL: https://github.com/nodejs/node/pull/23305
Reviewed-By: Anna Henningsen 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Colin Ihrig 
Reviewed-By: Trivikram Kamat

src: use String::Utf8Length with isolate

2018-08-29T10:28:19+00:00

PR-URL: https://github.com/nodejs/node/pull/22531
Reviewed-By: Colin Ihrig 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: use String::Write{OneByte,Utf8} with isolate

2018-08-29T10:28:14+00:00

PR-URL: https://github.com/nodejs/node/pull/22531
Reviewed-By: Colin Ihrig 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell