delta/node-new.git, branch stabilize-modules github.com: nodejs/node.git doc: mark modules implementation as stable 2020-11-18T20:28:43+00:00 Guy Bedford guybedford@gmail.com 2020-10-23T18:50:44+00:00 b4758fffa1d7af5ace6ca06c416062b72af962be 






domain: improve deprecation warning text for DEP0097
2020-11-18T18:58:49+00:00

Anna Henningsen
anna.henningsen@mongodb.com

2020-11-16T16:50:30+00:00

b3b0c4347426094afe48c9e2562881e3e2b0c186

Because the following gives basically no actionable information
on its own, neither in the error message nor in the stack trace:

    (node:3187) [DEP0097] DeprecationWarning: Using a domain property in MakeCallback is deprecated. Use the async_context variant of MakeCallback or the AsyncResource class instead.
        at emitMakeCallbackDeprecation (domain.js:123:13)
        at process.topLevelDomainCallback (domain.js:135:5)
        at process.callbackTrampoline (internal/async_hooks.js:124:14)

PR-URL: https://github.com/nodejs/node/pull/36136
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>





Because the following gives basically no actionable information
on its own, neither in the error message nor in the stack trace:

    (node:3187) [DEP0097] DeprecationWarning: Using a domain property in MakeCallback is deprecated. Use the async_context variant of MakeCallback or the AsyncResource class instead.
        at emitMakeCallbackDeprecation (domain.js:123:13)
        at process.topLevelDomainCallback (domain.js:135:5)
        at process.callbackTrampoline (internal/async_hooks.js:124:14)

PR-URL: https://github.com/nodejs/node/pull/36136
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>







tools: remove bashisms from license builder script
2020-11-18T18:58:35+00:00

Antoine du Hamel
duhamelantoine1995@gmail.com

2020-11-14T17:37:50+00:00

ed26808bdf1606017950b87fdc5bbdabf18d85ae

PR-URL: https://github.com/nodejs/node/pull/36122
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>





PR-URL: https://github.com/nodejs/node/pull/36122
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>







doc,url: fix url.hostname example
2020-11-18T18:53:41+00:00

Rishabh Mehan
darkrishabh@gmail.com

2020-06-05T08:23:22+00:00

665da27e7e8d11a70d57468af806eb7493529da8

PR-URL: https://github.com/nodejs/node/pull/33735
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>





PR-URL: https://github.com/nodejs/node/pull/33735
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>







fs: filehandle read now accepts object as argument
2020-11-18T18:50:44+00:00

Nikola Glavina
glavina.nikola5@gmail.com

2020-11-14T00:53:49+00:00

d05c271f175891c9eb390969a6e24ffadfc04eb3

PR-URL: https://github.com/nodejs/node/pull/34180
Fixes: https://github.com/nodejs/node/issues/34176
Refs: https://nodejs.org/api/fs.html#fs_filehandle_read_options
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>





PR-URL: https://github.com/nodejs/node/pull/34180
Fixes: https://github.com/nodejs/node/issues/34176
Refs: https://nodejs.org/api/fs.html#fs_filehandle_read_options
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>







build: try “python3” as a last resort for 3.x
2020-11-18T18:49:24+00:00

Ole André Vadla Ravnås
oleavr@gmail.com

2020-11-05T20:57:50+00:00

fb24f6e68828864463cc2f41b03c3da3412be364

So that Xcode's Python 3 gets picked up.

PR-URL: https://github.com/nodejs/node/pull/35983
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>





So that Xcode's Python 3 gets picked up.

PR-URL: https://github.com/nodejs/node/pull/35983
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>







test: fix typo in inspector-helper.js
2020-11-18T17:54:05+00:00

Luigi Pinca
luigipinca@gmail.com

2020-11-15T07:37:14+00:00

0ed9961f1239a3d9f79334dc8b7f0a3ba6c6fee2

PR-URL: https://github.com/nodejs/node/pull/36127
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>





PR-URL: https://github.com/nodejs/node/pull/36127
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>







test: deflake test-http-destroyed-socket-write2
2020-11-18T17:49:24+00:00

Luigi Pinca
luigipinca@gmail.com

2020-11-14T17:46:19+00:00

e682814c8f2f51f6c4643a2c1d0e473994473c38

Ensure that the write occurs in the same tick where the socket is
destroyed by the other peer.

PR-URL: https://github.com/nodejs/node/pull/36120
Fixes: https://github.com/nodejs/node/issues/36081
Fixes: https://github.com/nodejs/node/issues/4066
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>





Ensure that the write occurs in the same tick where the socket is
destroyed by the other peer.

PR-URL: https://github.com/nodejs/node/pull/36120
Fixes: https://github.com/nodejs/node/issues/36081
Fixes: https://github.com/nodejs/node/issues/4066
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>







timers: refactor to use more primordials
2020-11-18T12:21:24+00:00

Antoine du Hamel
duhamelantoine1995@gmail.com

2020-11-15T17:12:43+00:00

bd120207fbfffd4b6571c6d7c149c9bae5c46e01

PR-URL: https://github.com/nodejs/node/pull/36132
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>





PR-URL: https://github.com/nodejs/node/pull/36132
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>







doc: clarify text about process not responding
2020-11-18T12:17:31+00:00

Rich Trott
rtrott@gmail.com

2020-11-14T14:59:58+00:00

8938d37251d3a48686825b477339ca3991a9d37b

The existing text about processes not responding is unclear, at least to
me. Suggestions for clarification welcome, but I think the best thing
might be to state that the process may stop responding and leave it at
that. The explanantion (about asynchronous listeners) is not clear to
me. (Why would the fact that the listeners are asynchronous matter?) If
it's an unnecessary detail (as seems likely), let's remove it.

PR-URL: https://github.com/nodejs/node/pull/36117
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>





The existing text about processes not responding is unclear, at least to
me. Suggestions for clarification welcome, but I think the best thing
might be to state that the process may stop responding and leave it at
that. The explanantion (about asynchronous listeners) is not clear to
me. (Why would the fact that the listeners are asynchronous matter?) If
it's an unnecessary detail (as seems likely), let's remove it.

PR-URL: https://github.com/nodejs/node/pull/36117
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>