delta/node-new.git, branch sam-github-tsc

doc: move sam-github to TSC Emeriti

2020-06-28T04:40:12+00:00

I don't have enough time to remain active in the TSC, so I will step down.

doc: clarify require/import mutual exclusivity

2020-06-28T04:18:54+00:00

PR-URL: https://github.com/nodejs/node/pull/33832
Reviewed-By: Jan Krems 
Reviewed-By: Geoffrey Booth

vm: add run-after-evaluate microtask mode

2020-06-26T18:41:33+00:00

This allows timeouts to apply to e.g. `Promise`s and `async function`s
from code running inside of `vm.Context`s, by giving the Context its
own microtasks queue.

Fixes: https://github.com/nodejs/node/issues/3020

PR-URL: https://github.com/nodejs/node/pull/34023
Reviewed-By: James M Snell 
Reviewed-By: Denys Otrishko

doc: add dynamic source code links

2020-06-26T17:25:14+00:00

Fixes: https://github.com/nodejs/node/pull/33977

PR-URL: https://github.com/nodejs/node/pull/33996
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell

test: add non-ASCII character embedding test

2020-06-26T17:13:13+00:00

Add a test that verifies that non-ASCII characters may be used
in the source code provided to `LoadEnvironment()`.

PR-URL: https://github.com/nodejs/node/pull/33972
Reviewed-By: James M Snell

doc: specify maxHeaderCount alias for maxHeaderListPairs

2020-06-26T17:09:28+00:00

Fixes: https://github.com/nodejs/node/issues/32388

PR-URL: https://github.com/nodejs/node/pull/33519
Reviewed-By: Rich Trott 
Reviewed-By: Zeyu Yang 
Reviewed-By: James M Snell

src: add errorProperties on process.report

2020-06-26T17:06:22+00:00

PR-URL: https://github.com/nodejs/node/pull/28426
Reviewed-By: Gireesh Punathil 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

events: fix add-remove-add case in EventTarget

2020-06-26T02:28:45+00:00

Make sure that listeners are added properly if there has previously
been one but currently are none for a given event type.

PR-URL: https://github.com/nodejs/node/pull/34056
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

Revert "repl: always check for NODE_REPL_MODE environment variable"

2020-06-26T02:18:55+00:00

This reverts commit b831b081c499a614c1ee3f0272c9de1783395402.

This presumably unbreaks the ASAN github action build.

Example failure:

    2020-06-25T19:59:15.1448178Z === release test-repl-envvars ===
    2020-06-25T19:59:15.1448872Z Path: parallel/test-repl-envvars
    2020-06-25T19:59:15.1449449Z --- stderr ---
    2020-06-25T19:59:15.1449835Z assert.js:103
    2020-06-25T19:59:15.1450194Z   throw new AssertionError(obj);
    2020-06-25T19:59:15.1450524Z   ^
    2020-06-25T19:59:15.1450817Z
    2020-06-25T19:59:15.1451431Z AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
    2020-06-25T19:59:15.1452000Z + actual - expected
    2020-06-25T19:59:15.1452298Z
    2020-06-25T19:59:15.1452634Z   {
    2020-06-25T19:59:15.1452978Z     terminal: true,
    2020-06-25T19:59:15.1453321Z +   useColors: false
    2020-06-25T19:59:15.1453861Z -   useColors: true
    2020-06-25T19:59:15.1454225Z   }
    2020-06-25T19:59:15.1454841Z     at /home/runner/work/node/node/test/parallel/test-repl-envvars.js:55:12
    2020-06-25T19:59:15.1455246Z     at internal/repl.js:33:5

PR-URL: https://github.com/nodejs/node/pull/34058
Reviewed-By: James M Snell 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Rich Trott

fs: fix readdir failure when libuv returns UV_DIRENT_UNKNOWN

2020-06-25T18:58:50+00:00

Fixes: https://github.com/nodejs/node/issues/33348

PR-URL: https://github.com/nodejs/node/pull/33395
Refs: https://github.com/nodejs/node/issues/33348
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell