delta/node-new.git, branch pull-request-doc-updates

squash: incorporate feedback from contributors

2019-02-06T19:00:52+00:00

doc: add a sentence about REPLACEME in code changes

2019-02-06T15:14:47+00:00

When adding to the REPL API recently, I was unsure what to put as a
version number for the new method I added. This change adds a reference
to `releases.md` where the use of `REPLACEME` is discussed.

report: include information about event loop itself

2019-02-06T14:36:24+00:00

PR-URL: https://github.com/nodejs/node/pull/25906
Reviewed-By: Colin Ihrig 
Reviewed-By: Richard Lau 
Reviewed-By: James M Snell

child_process: close pipe ends that are re-piped

2019-02-06T12:20:46+00:00

when t0 and t1 are spawned with t0's outputstream [1, 2] is piped into
t1's input, a new pipe is created which uses a copy of the t0's fd.
This leaves the original copy in Node parent, unattended. Net result is
that when t0 produces data, it gets bifurcated into both the copies

Detect the passed handle to be of 'wrap' type and close after the
native spawn invocation by which time piping would have been over.

Fixes: https://github.com/nodejs/node/issues/9413
Fixes: https://github.com/nodejs/node/issues/18016

PR-URL: https://github.com/nodejs/node/pull/21209
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen

test: remove obsolete code

2019-02-06T06:37:48+00:00

The removed line does not add anything of value to the test. It was
removed to simplify the test.

PR-URL: https://github.com/nodejs/node/pull/25731
Reviewed-By: Michaël Zasso 
Reviewed-By: Ben Noordhuis

repl: remove obsolete buffer clearing

2019-02-06T06:37:48+00:00

It is checked if an command buffer exists or not. This code branch
can only be reached if none exist, so there's no need to clear that
buffer again.

PR-URL: https://github.com/nodejs/node/pull/25731
Reviewed-By: Michaël Zasso 
Reviewed-By: Ben Noordhuis

repl: fix eval return value

2019-02-06T06:30:39+00:00

In case no error has occurred during the evaluation of some code,
`undefined` has been returned in some cases as error argument instead
of `null`. This is fixed by this patch.

PR-URL: https://github.com/nodejs/node/pull/25731
Reviewed-By: Michaël Zasso 
Reviewed-By: Ben Noordhuis

repl: simplify and improve completion

2019-02-06T06:30:28+00:00

The completion lists used a hand crafted list of global entries that
was redundant due to also using the actual global properties for tab
completion. Those entries ended up in an separated completion group
which did not seem useful.

PR-URL: https://github.com/nodejs/node/pull/25731
Reviewed-By: Michaël Zasso 
Reviewed-By: Ben Noordhuis

meta: clarify EoL platform support

2019-02-06T06:18:01+00:00

PR-URL: https://github.com/nodejs/node/pull/25838
Reviewed-By: Jeremiah Senkpiel 
Reviewed-By: Michaël Zasso 
Reviewed-By: Сковорода Никита Андреевич 
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott 
Reviewed-By: Richard Lau

deps: patch to fix *.onion MX query on c-ares

2019-02-06T05:15:18+00:00

c-ares rejects *.onion MX query but forgot to set `*bufp` to NULL. This
will occur SegmentFault when free `*bufp`.

I make this quick fix and then will make a PR for c-ares either.

PR-URL: https://github.com/nodejs/node/pull/25840
Fixes: https://github.com/nodejs/node/issues/25839
Refs: https://github.com/c-ares/c-ares/blob/955df98/ares_create_query.c#L97-L103
Refs: https://github.com/c-ares/c-ares/blob/955df98/ares_query.c#L124
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: Richard Lau 
Reviewed-By: James M Snell