delta/node-new.git, branch ofrobots-patch-1

doc: add Backport-PR-URL info in backport guide

2018-10-19T05:38:17+00:00

util: treat format arguments equally

2018-10-17T17:56:43+00:00

Two changes here which bring us closer to the console standard:

- Arguments to `util.format` are no longer formatted differently
  depending on their order, with format strings being an exception.
- Format specifier formatting is now only triggered if the string
  actually contains a format string.

Under the hood, we now use a single shared function to format the given
arguments which will make the code easier to read and modify.

PR-URL: https://github.com/nodejs/node/pull/23162
Fixes: https://github.com/nodejs/node/issues/23137
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Refael Ackermann

src: changed stdio_pipes_ to std::vector

2018-10-17T17:20:43+00:00

PR-URL: https://github.com/nodejs/node/pull/23615
Reviewed-By: Sam Ruby 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Refael Ackermann

tls: prevent multiple connection errors

2018-10-17T16:51:20+00:00

onConnectEnd(), which is called by TLSSocket, has a guard to
prevent being called multiple times, but it does not prevent the
OpenSSL error handler from being called, leading to multiple
error events. This commit adds that piece of missing logic.

PR-URL: https://github.com/nodejs/node/pull/23636
Fixes: https://github.com/nodejs/node/issues/23631
Reviewed-By: Anna Henningsen 
Reviewed-By: Wyatt Preul 
Reviewed-By: James M Snell

crypto: simplify internal state handling

2018-10-17T16:48:30+00:00

Uninitialized instances are not exposed to users, so this condition should
always be true.

PR-URL: https://github.com/nodejs/node/pull/23648
Reviewed-By: Refael Ackermann 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ben Noordhuis

crypto: simplify error handling in ECDH::New

2018-10-17T16:45:26+00:00

The type of the argument is being checked within JS which makes the
type checking in C++ unnecessary.

PR-URL: https://github.com/nodejs/node/pull/23647
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen

src: update v8::Object::GetPropertyNames() usage

2018-10-17T16:26:18+00:00

Use the non-deprecated version of GetPropertyNames().

PR-URL: https://github.com/nodejs/node/pull/23660
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Gus Caplan 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: James M Snell

doc: cleanup and references in C++ guide

2018-10-16T21:47:49+00:00

PR-URL: https://github.com/nodejs/node/pull/23650
Reviewed-By: Anna Henningsen 
Reviewed-By: Joyee Cheung

src: remove OCB support ifdef OPENSSL_NO_OCB

2018-10-16T21:26:47+00:00

Electron uses BoringSSL which does not support OCB . It is also
possible to build OpenSSL without support for OCB for Node.js.
This commit disables OCB if OPENSSL_NO_OCB is defined.

PR-URL: https://github.com/nodejs/node/pull/23635
Reviewed-By: Tobias Nießen 
Reviewed-By: Anna Henningsen

deps: patch V8 to 7.0.276.28

2018-10-16T19:18:31+00:00

Refs: https://github.com/v8/v8/compare/7.0.276.25...7.0.276.28

PR-URL: https://github.com/nodejs/node/pull/23424
Reviewed-By: Anna Henningsen 
Reviewed-By: Refael Ackermann 
Reviewed-By: Colin Ihrig 
Reviewed-By: Yang Guo 
Reviewed-By: James M Snell 
Reviewed-By: Ali Ijaz Sheikh