delta/node-new.git, branch mafintosh-patch-1

Document allowHalfOpen in net.connect

2020-04-07T15:55:50+00:00

test: fix check error name on error instance

2020-04-07T00:02:43+00:00

PR-URL: https://github.com/nodejs/node/pull/32508
Reviewed-By: Luigi Pinca 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

doc: update Ninja information in build guide

2020-04-06T21:49:14+00:00

PR-URL: https://github.com/nodejs/node/pull/32629
Reviewed-By: Sam Roberts 
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott 
Reviewed-By: Jiawen Geng

src: munmap(2) upon class instance destructor

2020-04-06T19:54:53+00:00

Replace `OnScopeLeave` with a class whose instance destructor performs
the munmap(2).

Signed-off-by: Gabriel Schulhof 
Fixes: https://github.com/nodejs/node/issues/32532
PR-URL: https://github.com/nodejs/node/pull/32570
Co-Authored-By: Anna Henningsen 
Co-Authored-By: Ben Noordhuis 
Reviewed-By: Anna Henningsen 
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell 
Reviewed-By: David Carlier

stream: complete pipeline with stdio

2020-04-06T19:48:25+00:00

stdio (stderr & stdout) should for compatibility
reasons not be closed/end():ed. However, this
causes pipeline with a stdio destination to
never finish. This commit fixes this issue at
a performance cost.

Refs: https://github.com/nodejs/node/issues/7606

Fixes: https://github.com/nodejs/node/issues/32363

PR-URL: https://github.com/nodejs/node/pull/32373
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina

Revert "test: mark empty udp tests flaky on OS X"

2020-04-06T16:29:16+00:00

This reverts commit 24a4f76709bd9edc8d86e9f3fb4d5e3c7d4c3d69.

PR-URL: https://github.com/nodejs/node/pull/32489
Reviewed-By: Anna Henningsen 
Reviewed-By: Beth Griggs

src: consistently declare BindingData class

2020-04-06T15:44:07+00:00

Its defined as a class, so forward declare as a class, fixing type
mismatch warning.

PR-URL: https://github.com/nodejs/node/pull/32677
Reviewed-By: Anna Henningsen 
Reviewed-By: Richard Lau

async_hooks: move to lazy destroy hook registration in AsyncResource

2020-04-06T14:14:43+00:00

PR-URL: https://github.com/nodejs/node/pull/32429
Reviewed-By: Gerhard Stöbich 
Reviewed-By: Vladimir de Turckheim

build: use tabs for indentation in Makefile

2020-04-06T00:59:36+00:00

PR-URL: https://github.com/nodejs/node/pull/32614
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat

net: fix crash if POLLHUP is received

2020-04-06T00:58:53+00:00

If the `onread` socket option is used and a `POLLHUP` event is received,
libuv returns `UV_EOF` along with a `NULL` buffer in the read callback,
causing the crash. Deal with this case.

Fixes: https://github.com/nodejs/node/issues/31823

PR-URL: https://github.com/nodejs/node/pull/32590
Reviewed-By: Anna Henningsen 
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell