delta/node-new.git, branch Remove-Python-3-tests

build: remove experimental Python 3 tests

2019-09-03T06:21:52+00:00

These tests do not help us to get closer to Python 3 compatibility and they take up valuable time yet they always fail.

tools: update ESLint to 6.3.0

2019-09-03T04:51:40+00:00

Update ESLint to 6.3.0

PR-URL: https://github.com/nodejs/node/pull/29382
Reviewed-By: Rich Trott 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Yongsheng Zhang

build,win: accept Python 3 if 2 is not available

2019-09-03T04:07:08+00:00

If there is no Python 2 available, use Python 3. This allows to test
running configure with Python 3.

PR-URL: https://github.com/nodejs/node/pull/29236
Reviewed-By: Christian Clauss 
Reviewed-By: Rich Trott

build,win: find Python in paths with spaces

2019-09-03T04:07:06+00:00

When looking for Python in the registry, as specified in PEP514,
this was not able to handle installations in a path with spaces,
like Program Files. This ensures the whole path is used, fixing the
issue.

PR-URL: https://github.com/nodejs/node/pull/29236
Reviewed-By: Christian Clauss 
Reviewed-By: Rich Trott

lib: add ASCII fast path to getStringWidth()

2019-09-03T04:02:34+00:00

A lot of strings that are going to be passed to `getStringWidth()`
are ASCII strings, for which the calculation is rather easy and
calling into C++ can be skipped.

                                                       confidence improvement accuracy (*)    (**)   (***)
     misc/getstringwidth.js n=100000 type='ascii'            ***    328.99 %      ±21.73% ±29.25% ±38.77%
     misc/getstringwidth.js n=100000 type='emojiseq'                  2.94 %       ±7.66% ±10.19% ±13.26%
     misc/getstringwidth.js n=100000 type='fullwidth'                 4.70 %       ±5.64%  ±7.50%  ±9.76%

PR-URL: https://github.com/nodejs/node/pull/29301
Reviewed-By: Gus Caplan 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Minwoo Jung 
Reviewed-By: Rich Trott

tools: use 'from io import StringIO' in ninja.py

2019-09-03T04:01:09+00:00

PR-URL: https://github.com/nodejs/node/pull/29371
Reviewed-By: Ben Noordhuis 
Reviewed-By: Jiawen Geng 
Reviewed-By: Richard Lau 
Reviewed-By: Luigi Pinca

Revert "build: add full Python 3 tests to Travis CI"

2019-09-03T03:27:01+00:00

Reverted for breaking the Travis CI builds with the following error:

    $ cp ${PYTHON2_CACHE}/node out/Release/node

    cp: cannot stat '/home/travis/.ccache/py2.7.15/node': No such file
    or directory

    The command "cp ${PYTHON2_CACHE}/node out/Release/node" failed and
    exited with 1 during .

This reverts commit c602b0a4e5df8de90299637aaef65c4cedae30ac.

Refs: https://github.com/nodejs/node/pull/29360

PR-URL: https://github.com/nodejs/node/pull/29406
Reviewed-By: Jiawen Geng 
Reviewed-By: David Carlier 
Reviewed-By: Colin Ihrig 
Reviewed-By: Richard Lau 
Reviewed-By: Christian Clauss 
Reviewed-By: Anto Aravinth

stream: don't deadlock on aborted stream

2019-09-02T14:31:33+00:00

Not all streams (e.g. http.ClientRequest) will always emit
'close' after 'aborted'.

PR-URL: https://github.com/nodejs/node/pull/29376
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca

tools: fix mksnapshot blob wrong freeing operator

2019-09-02T06:52:42+00:00

PR-URL: https://github.com/nodejs/node/pull/29384
Reviewed-By: Ben Noordhuis 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: Joyee Cheung

console: use getStringWidth() for character width calculation

2019-09-02T06:13:58+00:00

This is more accurate for displayed full-width characters
(e.g. CJK ones) and makes the calculations match the ones we
use in the readline module.

Fixes: https://github.com/nodejs/node/issues/29299

PR-URL: https://github.com/nodejs/node/pull/29300
Reviewed-By: Gus Caplan 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Yongsheng Zhang 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell