delta/node-new.git/.github/PULL_REQUEST_TEMPLATE.md, branch try_Python3_on_macOS

doc: add dco to github pr template

2019-08-26T16:52:50+00:00

Our project relies on the Developer Certificate of Origin as a passive
alternative to a Contributor License Agreement. The PR template seems
like a great place to surface the text to help new contributors be
aware of the DCO and it's implications.

PR-URL: https://github.com/nodejs/node/pull/24023
Reviewed-By: Ali Ijaz Sheikh 
Reviewed-By: Matteo Collina 
Reviewed-By: Matheus Marchini 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: Colin Ihrig 
Reviewed-By: Richard Lau

doc: remove subsystem from pull request template

2018-03-06T08:33:16+00:00

Remove request that user provide a list of subsystems in the pull
request template.

* We already ask them to put the subsystems in the first line of the
  commit message.
* The subsystem is usually easy to determine.
* We have a bot that applies subsystem labels on new PRs and it seems to
  do a rather good job. Tools over rules. Let the bot do it.
* The fewer unnecessary things we ask for in the template, the lower the
  barrier to entry.
* Anecdotal, but I have never found it useful to have the person
  submitting the PR list out subsystems in the pull request post.

PR-URL: https://github.com/nodejs/node/pull/19125
Reviewed-By: Luigi Pinca 
Reviewed-By: Michaël Zasso 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Tobias Nießen 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Сковорода Никита Андреевич 
Reviewed-By: Gibson Fahnestock 
Reviewed-By: Gus Caplan 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Colin Ihrig 
Reviewed-By: Matheus Marchini 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: James M Snell 
Reviewed-By: Jon Moss 
Reviewed-By: Kyle Farnung

doc: split CONTRIBUTING.md

2018-01-23T19:23:40+00:00

PR-URL: https://github.com/nodejs/node/pull/18271
Fixes: https://github.com/nodejs/node/issues/17842
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: Gibson Fahnestock 
Reviewed-By: James M Snell

doc: fix commit guideline url

2017-05-05T22:01:28+00:00

PR-URL: https://github.com/nodejs/node/pull/12862
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Jeremiah Senkpiel 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott

doc: update pull request template URL layout

2017-04-06T01:41:38+00:00

Putting the link for the commit guideline at the bottom of the pull
request template makes it a bit confusing when opening a pull request as
the markdown does not render. Not everyone is familiar with the syntax
used there and it is easy to mess it up (for example, by not leaving a
blank line above it). It is more natural and useful if the URL is
included inline.

PR-URL: https://github.com/nodejs/node/pull/12216
Reviewed-By: Gibson Fahnestock 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Sam Roberts 
Reviewed-By: James M Snell 
Reviewed-By: Yuta Hiroto 
Reviewed-By: Richard Lau 
Reviewed-By: Timothy Gu 
Reviewed-By: Colin Ihrig

doc: linkable commit message guidelines

2017-03-16T22:42:57+00:00

Put the commit guidelines themselves under a heading to be more
prominent, and to allow linking directly to them (instead of the section
on how to use git).

Link the pull request template to the guidelines, so contributors can
find them.

PR-URL: https://github.com/nodejs/node/pull/11792
Reviewed-By: Rich Trott 
Reviewed-By: Joyee Cheung 
Reviewed-By: Luigi Pinca 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

meta: modify pull request template for prepending

2016-12-29T17:58:10+00:00

The GitHub interface for new pull requests has started prepending
commit messages for single-commit pull requests. It had previously
been appending them. Modify the GitHub template to accommodate the new
behavior.

PR-URL: https://github.com/nodejs/node/pull/10484
Reviewed-By: James M Snell 
Reviewed-By: Michaël Zasso 
Reviewed-By: Gibson Fahnestock 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Prince John Wesley 
Reviewed-By: Сковорода Никита Андреевич 
Reviewed-By: Sam Roberts 
Reviewed-By: Myles Borins

build: change nosign flag to sign and flips logic

2016-12-18T01:19:34+00:00

Makes the default build on Windows not try to sign the node.exe
binary after a build. Instead the 'sign' flag now indicates that the
binary should be signed. The 'nosign' flag is left as a noop.

Reviewed-By: Nikolai Vavilov 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Bartosz Sosnowski 
Reviewed-By: Michael Dawson 
Reviewed-By: Colin Ihrig 
Reviewed-By: João Reis 
PR-URL: https://github.com/nodejs/node/pull/10156

doc: standardizing on make -j4

2016-12-09T20:53:20+00:00

Standardizes docs to use -j4 instead of -j8 as it appears to be the
most inclusive recommendation based on discussion in
https://github.com/nodejs/node/pull/9961.

PR-URL: https://github.com/nodejs/node/pull/9961
Reviewed-By: Jeremiah Senkpiel 
Reviewed-By: James M Snell 
Reviewed-By: Gibson Fahnestock 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Stephen Belanger

doc: standardize on `make -j8`

2016-09-23T03:11:24+00:00

Most of the docs recommend `make -j8`. The one exception is the pull
request template which recommends `make -j4`. This changes the pull
request template so that it is in line with the other docs.

PR-URL: https://github.com/nodejs/node/pull/8678
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
Reviewed-By: Johan Bergström 
Reviewed-By: Ilkka Myller 
Reviewed-By: Michael Dawson 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Gibson Fahnestock