From 2e225838696e89a3f86e3a0134de51dcc9e9a01f Mon Sep 17 00:00:00 2001 From: joe Date: Mon, 24 Sep 2018 10:52:50 +0000 Subject: * src/ne_xml.c (ne_xml_parse): Avoid clang warning from strcpy use. * src/ne_session.c (ne__ssl_set_verify_err): Ditto. * src/ne_request.c (body_fd_send): Ditto. git-svn-id: http://svn.webdav.org/repos/projects/neon/trunk@2017 61a7d7f5-40b7-0310-9c16-bb0ea8cb1845 --- src/ne_request.c | 2 +- src/ne_session.c | 3 ++- src/ne_xml.c | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/ne_request.c b/src/ne_request.c index 7cb69a6..66991c6 100644 --- a/src/ne_request.c +++ b/src/ne_request.c @@ -329,7 +329,7 @@ static ssize_t body_fd_send(void *userdata, char *buffer, size_t count) /* errno was set */ ne_strerror(errno, err, sizeof err); } else { - strcpy(err, _("offset invalid")); + ne_strnzcpy(err, _("offset invalid"), sizeof err); } ne_snprintf(offstr, sizeof offstr, "%" FMT_NE_OFF_T, req->body.file.offset); diff --git a/src/ne_session.c b/src/ne_session.c index 6e1f395..f883585 100644 --- a/src/ne_session.c +++ b/src/ne_session.c @@ -569,7 +569,8 @@ void ne__ssl_set_verify_err(ne_session *sess, int failures) }; int n, flag = 0; - strcpy(sess->error, _("Server certificate verification failed: ")); + ne_strnzcpy(sess->error, _("Server certificate verification failed: "), + sizeof sess->error); for (n = 0; reasons[n].bit; n++) { if (failures & reasons[n].bit) { diff --git a/src/ne_xml.c b/src/ne_xml.c index c3a88ca..7dd823b 100644 --- a/src/ne_xml.c +++ b/src/ne_xml.c @@ -576,7 +576,7 @@ int ne_xml_parse(ne_xml_parser *p, const char *block, size_t len) if (p->bom_pos == 0) { p->bom_pos = 3; /* no BOM */ } else if (p->bom_pos > 0 && p->bom_pos < 3) { - ne_strnzcpy(p->error, sizeof p->error, _("Invalid Byte Order Mark")); + ne_strnzcpy(p->error, _("Invalid Byte Order Mark"), sizeof p->error); return p->failure = 1; } } -- cgit v1.2.1