From b74329764358cd2e34c87f5a235967f3736dd04d Mon Sep 17 00:00:00 2001 From: Joseph Herlant Date: Thu, 24 May 2018 13:19:01 -0700 Subject: fix:maptool:coverity #262887 - leaked_storage: Variable f going out of scope leaks the storage it points to. (#598) --- navit/maptool/buffer.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'navit/maptool') diff --git a/navit/maptool/buffer.c b/navit/maptool/buffer.c index 68160f789..35f804b5e 100644 --- a/navit/maptool/buffer.c +++ b/navit/maptool/buffer.c @@ -71,13 +71,14 @@ load_buffer(char *filename, struct buffer *b, long long offset, long long size) } b->size=b->malloced=size; dbg_assert(b->size>0); - + fseeko(f, offset, SEEK_SET); b->base=g_malloc(b->size); if (fread(b->base, b->size, 1, f) == 0){ dbg(lvl_warning, "fread failed"); + fclose(f); return 0; - } + } fclose(f); return 1; } -- cgit v1.2.1