From 97f10a0d215388c3d2870847b2d38a719bcfe001 Mon Sep 17 00:00:00 2001 From: Ray Strode Date: Fri, 25 Sep 2020 14:04:31 -0400 Subject: barriers: Fix leak in meta_barrier_destroy meta_barrier_destroy is responsible for removing the extra reference added in meta_barrier_constructed. Unfortunately, it fails to do this because of a misplaced early return statement. This commit removes the spurious return. https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1449 --- src/backends/meta-barrier.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backends/meta-barrier.c b/src/backends/meta-barrier.c index e163338cb..ad6c8d583 100644 --- a/src/backends/meta-barrier.c +++ b/src/backends/meta-barrier.c @@ -294,7 +294,7 @@ meta_barrier_destroy (MetaBarrier *barrier) MetaBarrierImpl *impl = barrier->priv->impl; if (impl) - return META_BARRIER_IMPL_GET_CLASS (impl)->destroy (impl); + META_BARRIER_IMPL_GET_CLASS (impl)->destroy (impl); g_object_unref (barrier); } -- cgit v1.2.1