delta/mutter.git/src/tests/stacking, branch document-button-values gitlab.gnome.org: GNOME/mutter.git tests/stacking: Add test hiding a modal with a not shown parent 2020-12-18T17:17:50+00:00 Jonas Ådahl jadahl@gmail.com 2020-12-16T22:27:19+00:00 c94d929332d9371646fde15668097c4ea136147c This adds a test case for https://gitlab.gnome.org/GNOME/mutter/-/issues/862 that checks that hiding a dialog where its parent is not yet shown doesn't trigger any asserts or crashes. Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1643> 
This adds a test case for
https://gitlab.gnome.org/GNOME/mutter/-/issues/862 that checks that
hiding a dialog where its parent is not yet shown doesn't trigger any
asserts or crashes.

Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1643>
tests/stacking: Add test for when no default focus window can be found 2020-06-26T21:00:12+00:00 Sebastian Keller skeller@gnome.org 2020-06-26T19:32:39+00:00 d85c3c1e940a6f42a4f38cf3ad9f8768a90485df The previous commit removed checks for intermediate focus states which would make tests randomly fail, because of their time dependence. What can be tested however is that if there is no other window available that would accept the focus, that the focus remains at 'none', after the focused window has been closed. This newly introduced test checks the focus directly after closing the window (and syncing) and after the time it would have taken for the queue to finish. The first check has a similar timing issue as the removed focus checks in the other tests, but the test will never accidentally fail, because regardless of whether the queue has finished or not, the focus is always expected to be 'none'. https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1329 
The previous commit removed checks for intermediate focus states which
would make tests randomly fail, because of their time dependence. What
can be tested however is that if there is no other window available that
would accept the focus, that the focus remains at 'none', after the
focused window has been closed. This newly introduced test checks the
focus directly after closing the window (and syncing) and after the time
it would have taken for the queue to finish. The first check has a
similar timing issue as the removed focus checks in the other tests, but
the test will never accidentally fail, because regardless of whether the
queue has finished or not, the focus is always expected to be 'none'.

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1329
tests/stacking: Don't test for time-dependent intermediate focus state 2020-06-26T21:00:12+00:00 Sebastian Keller skeller@gnome.org 2020-06-26T19:31:10+00:00 d830d985c19de9dfd970c010b0c1594f125791ac While c3d13203 ensured that the test-client has actually closed the window before testing for the focus change, it also made another timing related issue with the tests more likely to happen. Serveral tests assert that the focus is set to 'none' after the focussed window has been closed when the window below does not accept focus. This however can never be reliably tested, because closing the window triggers timeout based iteration of a queue of default focus candidate windows. This starts after the window has been closed and might finish before the clients have finished synchronizing. This issue is more likely to trigger the shorter the queue is and the more test clients there are that could delay the synchronization. https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1329 
While c3d13203 ensured that the test-client has actually closed the
window before testing for the focus change, it also made another timing
related issue with the tests more likely to happen. Serveral tests
assert that the focus is set to 'none' after the focussed window has
been closed when the window below does not accept focus. This however
can never be reliably tested, because closing the window triggers
timeout based iteration of a queue of default focus candidate windows.
This starts after the window has been closed and might finish before the
clients have finished synchronizing. This issue is more likely to
trigger the shorter the queue is and the more test clients there are
that could delay the synchronization.

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1329
tests/stacking: Avoid random failures in focus tests 2020-06-21T03:00:03+00:00 Sebastian Keller skeller@gnome.org 2020-06-20T22:40:18+00:00 c3d132034372297dd67dbe330059bcadac7b7713 Some tests were not waiting for the test client to actually issue destroy commands before checking their effect on the window focus. Similarly when mutter is supposed to change the focus based on a delay by sending a WM_TAKE_FOCUS to the client, this also could fail without synchronization with the client before checking the result. https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1325 
Some tests were not waiting for the test client to actually issue
destroy commands before checking their effect on the window focus.

Similarly when mutter is supposed to change the focus based on a delay
by sending a WM_TAKE_FOCUS to the client, this also could fail without
synchronization with the client before checking the result.

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1325
tests/stacking/restore-position: Always use wait_reconfigure 2020-05-29T14:47:10+00:00 Jonas Ådahl jadahl@gmail.com 2020-05-29T14:27:03+00:00 c5b1bdc0fe1d8e72b19a915453beec5ccdb3cedb wait_reconfigure ensures that the whole configure back and forth completes before continuing. Doing this after every state change ensures that we always end up with the expected state, thus fixes flakyness of the restore-position stacking test. https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1279 
wait_reconfigure ensures that the whole configure back and forth
completes before continuing. Doing this after every state change ensures
that we always end up with the expected state, thus fixes flakyness of
the restore-position stacking test.

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1279
tests/stacking: Add test checking the initial size 2020-05-07T23:15:25+00:00 Jonas Ådahl jadahl@gmail.com 2020-04-06T10:12:02+00:00 82470cd40da4e2caae6543af986005ee32575e2d https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1171 
https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1171
tests/stacking: Add test for checking restored positions 2020-05-07T23:15:25+00:00 Jonas Ådahl jadahl@gmail.com 2020-04-02T17:26:16+00:00 b4972f573c09784313e109633857bb7b9cefe3f8 Going maximized -> unmaximized should restore the previous position. The same for untiling, or going from tiled, to maximized, to floating. https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1171 
Going maximized -> unmaximized should restore the previous position. The
same for untiling, or going from tiled, to maximized, to floating.

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1171
tests/restore-size: Also test that untiling restores correctly 2020-05-07T23:15:25+00:00 Jonas Ådahl jadahl@gmail.com 2020-04-02T17:09:44+00:00 989e2ccc4693230968f5c302478d1788863bd853 Tiling, then untiling should restore to the size prior to tiling. Tiling, maximizing, then unmaximizing should also restore to the size prior to tiling. https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1171 
Tiling, then untiling should restore to the size prior to tiling.

Tiling, maximizing, then unmaximizing should also restore to the size
prior to tiling.

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1171
tests/stacking: Test some maximize fullscreen interaction 2020-05-07T23:15:24+00:00 Jonas Ådahl jadahl@gmail.com 2020-04-02T16:36:06+00:00 449cbe153b35d34724a292ef98b2051a5eb24de1 https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1171 
https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1171
tests/stacking: Check that unmaximize to new size works 2020-05-07T23:15:24+00:00 Jonas Ådahl jadahl@gmail.com 2020-04-02T16:22:34+00:00 d14c8cf9a4f7b4d6c43a7f26174e5de8de575c03 A client that set a new fallback size while being maximized should not restore to the one prior to being maximized. https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1171 
A client that set a new fallback size while being maximized should not
restore to the one prior to being maximized.

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1171