delta/mutter.git, branch gnome-3-36

wayland/surface: Do not uncoditionally process surface damage

2021-12-22T17:01:20+00:00

Most clients nowadays switched to buffer damage, most notably Mesa
and Xwayland. Thus lets avoid the extra cost of allocating three
`cairo_region_t`s and doing some calculations.

Part-of: 

(cherry picked from commit c498ae337f57a67c6e678d549cf9a8070c32f251)

wayland/surface: Use correct default viewport for surface damage

2021-12-22T17:01:15+00:00

If no viewport is set, the neutral viewport is the surface size
without viewport destination size applied - i.e. transform and
scale applied to the buffer size. Change it accordingly, giving
us the same values we'd return in `get_width` in this case.

As result, this only changes cases where a viewport destination
size but no viewport source rectangle is set.

The change fixes exactly such cases, e.g. the Gstreamer Wayland
sink. Can be tested with: `gst-play-1.0 --videosink=waylandsink`.

Part-of: 

(cherry picked from commit c1668116959664f04e509130e76a18d55429ca65)

wayland/surface: Switch order for calculating surface damage

2021-12-22T17:01:11+00:00

Process surface damage in the right order, simplifying the
calculations.

No functional change intended.

Part-of: 

(cherry picked from commit f4717d0ac51625d271f3a8cdc6804fa9461bc927)

xwayland: Fix condition for queuing a window to META_QUEUE_CALC_SHOWING

2021-10-04T08:29:14+00:00

This logic was changed by accident in df642eb15. The change caused every
Xwayland window to be queued to META_QUEUE_CALC_SHOWING on every surface
commit. As a result, X11 window management events, including _NET_WM_STATE,
were dispatched at clients on every single frame.

Fixes https://gitlab.gnome.org/GNOME/mutter/-/issues/1955

Part-of: 
(cherry picked from commit 98d5aa159e0eb9f433b211044ce30cd612d42734)

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2038

window-actor/wayland: Remove subsurface actors on dispose

2021-09-02T21:51:43+00:00

Destroying the window actor also destroys all its children. Subsurfaces
however may get reused. If the client did not unparent them before
the window actor got destroyed, they will be left without actor
which results in a crash.

Unparent all actors of subsurfaces on dispose to avoid that.

Closes https://gitlab.gnome.org/GNOME/mutter/-/issues/1892

Part-of:

wayland/subsurface: Handle node unlinking on parent destroyed

2021-09-02T21:47:50+00:00

It concerns subsurface state and the subsurface already listenes
for the parent to get destroyed.

Part-of:

wayland/subsurface: Check for parent actor before unparenting

2021-09-02T21:47:36+00:00

No need to assume the actor still has a parent. This silences warnings
in normal builds and prevents a crash in fully optimized ones.

Part-of:

shaped-texture: Fix damage propagation for rotated transforms with viewport

2021-04-22T16:59:22+00:00

When a viewport source rect or destination size is set, `stex->dst_width`
gives us the the cropped and/or scaled size. At this step, we need the
uncropped/unscaled size however.

Note: this is only ever relevant if buffer transform and viewport are
used together - otherwise the values are the same.


(cherry picked from commit 7d3e2c5f9c09fae50450df691eeba0f067de8cff)

Part-of:

wayland/subsurface: Avoid placement ops for detached subsurfaces

2021-04-22T16:59:22+00:00

If a subsurface first gets reordered and afterwards detached from
the parent before the parent surface got commited, we currently
would end up reattaching the subsurface to its previous parent.

While clients should avoid this behaviour, it's legit according
to the spec.

We already prevent similar cases where the subsurface is destroyed -
extend that check to detaching, which includes the destroy case.


(cherry picked from commit 6e00e5e6e7c7bab6c2ba408b528e1bdee8f17239)

Part-of:

window-actor/wayland: Cleaner subsurface reordering

2021-04-22T16:59:22+00:00

Currently when reordering subsurfaces, we un- and reparent all child
actors of the window actor. This is unnecessarily wasteful and
triggers bugs in clutter. While the underlying issue should be fixed
eventually, simply reorder the actors with the tools clutter provides
us with, avoiding those bugs and likely being faster as well.


(cherry picked from commit f7768874e5ec2a808ccec424ed9e238e3dc13987)

Part-of: