delta/mutter.git, branch gbsneto/graphene-ray

clutter/actor: Don't push identity transforms

2020-10-23T22:21:10+00:00

It is useless, and needlessly increases the matrix stack and
does more multiplications than necessary.

Don't push identity transforms to the pick stack.

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1509

clutter/pick-context: Remove clutter_pick_context_get_framebuffer()

2020-10-23T22:21:10+00:00

It is not used anymore.

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1509

clutter/actor: Remove cached inverse transform

2020-10-23T22:21:10+00:00

It is not used anymore.

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1509

Use graphene_ray_t to pick actors

2020-10-23T22:21:10+00:00

This commit introduces a few important changes in order to
acommodate graphene_ray_t. Most of them are positive changes,
so don't panic :)

The first very visible change is that neither the actor box
nor the clip rectangles are projected before being pushed.
This required changing the parameters of the related functions
at both ClutterPickContext, and ClutterPickStack, to receive
boxes instead of vertices. These rectangles are projected on
demand now, so in the best case (first actor picked) only
one projection happens; and in the worst case, it projects
as much as it does now.

The second important change is that there are no more checks
for axis-alignment anymore. That's because picking now happens
in 3D space, using triangles.

Talking about triangles in 3D space, this is what is used now
for picking. We break down each actor rectangle in 2 triangles,
and check if the projected pick point is inside any one of them,
of if the ray intersects any one of them. The same check happens
for the clip rectangles.

Checking the projected pick point is both an optimization for the
2D case, and a workaround to graphene_ray_t problems with float
precision, which is specially visible on edges such as the top
bar.

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1509

clutter/pick-stack: Store current matrix entry

2020-10-23T22:12:55+00:00

This is the beginning of the preparations to passing unprojected
rectangles to the clip stack. Store a ref to the current tip of
the matrix entry.

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1509

Introduce ClutterPickStack

2020-10-23T22:12:07+00:00

ClutterPickStack is a new boxed type that stores the vertices
and clip rectangles. It is meant to be a byproduct of picking,
and takes over most of what ClutterStage currently does.

It introduces a 'seal' system, inspired by MetaKmsUpdate. After
the pick operation is done, and the rectangles are collected,
the pick stack is sealed, and is not allowed to be externally
modified anymore. Internally, it still can invalidate pick
records when an actor is destroyed.

For now, it handles both the clip rectangles, and the matrix
stack, separatedly. Future commits will rearrange this.

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1509

clutter/stage: Remove useless cached pick mode reset

2020-10-23T22:05:00+00:00

It happens a couple of lines above, in _clutter_stage_clear_pick_stack().

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1509

clutter: Remove pick mode from context

2020-10-23T22:05:00+00:00

It is not used anywhere now.

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1509

clutter/actor: Remove '_paint' suffix from clutter_actor_should_pick_paint

2020-10-23T22:04:26+00:00

We're not using paint to pick anymore.

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1509

clutter/actor: Use pick context in clutter_actor_should_pick_paint()

2020-10-23T22:03:39+00:00

Pass the ClutterPickContext to clutter_actor_should_pick_paint() and
check the pick mode from it.

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1509