From ac2fc471a49d37cc00e4298cea276d8351fd5a8b Mon Sep 17 00:00:00 2001
From: Paul Zimmermann <Paul.Zimmermann@inria.fr>
Date: Sat, 8 Feb 2020 10:58:05 +0100
Subject: fixed bug in mpc_pow: wrong sign for infinite result

---
 src/pow.c    | 10 ++++++----
 tests/tpow.c | 35 +++++++++++++++++++++++++++++++++++
 2 files changed, 41 insertions(+), 4 deletions(-)

diff --git a/src/pow.c b/src/pow.c
index 67e7d94..ec9620a 100644
--- a/src/pow.c
+++ b/src/pow.c
@@ -680,11 +680,13 @@ mpc_pow (mpc_ptr z, mpc_srcptr x, mpc_srcptr y, mpc_rnd_t rnd)
       if (mpfr_get_exp (mpc_imagref(t)) > (mpfr_exp_t) q)
         q = mpfr_get_exp (mpc_imagref(t));
 
-      /* if q >= p, we get an error of order 1 on the imaginary part of t,
-         which is not enough to get the correct sign of exp(t) */
-      if (q >= p)
+      /* the signs of the real/imaginary parts of exp(t) are determined by the
+         quadrant of exp(i*imag(t)), which depends on imag(t) mod (2pi).
+         We ensure that p >= q + 64 to get enough precision, but this might
+         be not enough in corner cases (FIXME). */
+      if (p < q + 64)
         {
-          p = p + 64;
+          p = q + 64;
           goto try_again;
         }
 
diff --git a/tests/tpow.c b/tests/tpow.c
index 7cfcd3c..09dd09c 100644
--- a/tests/tpow.c
+++ b/tests/tpow.c
@@ -52,6 +52,39 @@ reuse_bug (void)
      }
 }
 
+/* at precision 53, mpc_pow gave (inf,-inf), and
+   at precision 73, it gave (inf,inf) */
+static void
+bug20200208 (void)
+{
+  mpc_t x, y, z, zr;
+  mpfr_prec_t prec1 = 53, prec2 = 73;
+
+  mpc_init2 (x, prec1);
+  mpc_init2 (y, prec1);
+  mpc_init2 (z, prec1);
+  mpc_init2 (zr, prec2);
+  mpfr_set_d (mpc_realref (x), 2.0851332234623992e-197, MPFR_RNDN);
+  mpfr_set_d (mpc_imagref (x), -5.6221457829327427e-17, MPFR_RNDN);
+  mpfr_set_d (mpc_realref (y), -2.1866902464899554e+138, MPFR_RNDN);
+  mpfr_set_d (mpc_imagref (y), 2.5932544562430328e-234, MPFR_RNDN);
+  mpc_pow (z, x, y, MPC_RNDNN);
+  mpc_pow (zr, x, y, MPC_RNDNN);
+  if (mpc_cmp (z, zr))
+    {
+      printf ("Inconsistent power with different precisions:\n");
+      mpfr_printf ("prec %lu: (%Re,%Re)\n",
+                   prec1, mpc_realref (z), mpc_imagref (z));
+      mpfr_printf ("prec %lu: (%Re,%Re)\n",
+                   prec2, mpc_realref (zr), mpc_imagref (zr));
+      exit (1);
+    }
+  mpc_clear (x);
+  mpc_clear (y);
+  mpc_clear (z);
+  mpc_clear (zr);
+}
+
 #define MPC_FUNCTION_CALL                                               \
   P[0].mpc_inex = mpc_pow (P[1].mpc, P[2].mpc, P[3].mpc, P[4].mpc_rnd)
 #define MPC_FUNCTION_CALL_REUSE_OP1                                     \
@@ -67,6 +100,8 @@ main (void)
 {
   test_start ();
 
+  bug20200208 ();
+
   reuse_bug ();
 
   data_check_template ("pow.dsc", "pow.dat");
-- 
cgit v1.2.1