<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/mesa.git/src/glsl/glsl_symbol_table.h, branch baserock/james/test</title>
<subtitle>gitlab.freedesktop.org: mesa/mesa.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/mesa.git/'/>
<entry>
<title>glsl: make consistent use of DECLARE_RALLOC_CXX_OPERATORS</title>
<updated>2014-10-02T04:59:35+00:00</updated>
<author>
<name>Ilia Mirkin</name>
<email>imirkin@alum.mit.edu</email>
</author>
<published>2014-09-30T04:12:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/mesa.git/commit/?id=3914dc579e816fbf7adef0038ab50f4660e78858'/>
<id>3914dc579e816fbf7adef0038ab50f4660e78858</id>
<content type='text'>
Signed-off-by: Ilia Mirkin &lt;imirkin@alum.mit.edu&gt;
Reviewed-by: Kenneth Graunke &lt;kenneth@whitecape.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Ilia Mirkin &lt;imirkin@alum.mit.edu&gt;
Reviewed-by: Kenneth Graunke &lt;kenneth@whitecape.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>glsl: Fix clang mismatched-tags warnings with glsl_type.</title>
<updated>2014-06-15T20:34:18+00:00</updated>
<author>
<name>Vinson Lee</name>
<email>vlee@freedesktop.org</email>
</author>
<published>2014-06-15T06:37:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/mesa.git/commit/?id=4133c7126c8c694ee4b05da1f312c411c0f6fdeb'/>
<id>4133c7126c8c694ee4b05da1f312c411c0f6fdeb</id>
<content type='text'>
Fix clang mismatched-tags warnings introduced with commit
4f5445a45d3ed02e00a061b10c943c0b079c6020.

./glsl_symbol_table.h:37:1: warning: class 'glsl_type' was previously declared as a struct [-Wmismatched-tags]
class glsl_type;
^
./glsl_types.h:86:8: note: previous use is here
struct glsl_type {
       ^
./glsl_symbol_table.h:37:1: note: did you mean struct here?
class glsl_type;
^~~~~

Signed-off-by: Vinson Lee &lt;vlee@freedesktop.org&gt;
Reviewed-by: Matt Turner &lt;mattst88@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix clang mismatched-tags warnings introduced with commit
4f5445a45d3ed02e00a061b10c943c0b079c6020.

./glsl_symbol_table.h:37:1: warning: class 'glsl_type' was previously declared as a struct [-Wmismatched-tags]
class glsl_type;
^
./glsl_types.h:86:8: note: previous use is here
struct glsl_type {
       ^
./glsl_symbol_table.h:37:1: note: did you mean struct here?
class glsl_type;
^~~~~

Signed-off-by: Vinson Lee &lt;vlee@freedesktop.org&gt;
Reviewed-by: Matt Turner &lt;mattst88@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>glsl: Remove unused include from glsl_symbol_table.h</title>
<updated>2014-06-10T20:05:51+00:00</updated>
<author>
<name>Thomas Helland</name>
<email>thomashelland90@gmail.com</email>
</author>
<published>2014-06-09T22:57:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/mesa.git/commit/?id=4f5445a45d3ed02e00a061b10c943c0b079c6020'/>
<id>4f5445a45d3ed02e00a061b10c943c0b079c6020</id>
<content type='text'>
Only function-defs use glsl_type so forward declare instead.
Compile-tested on my Ivy-bridge system.

IWYU also suggests removing #include &lt;new&gt;, and this compiles fine.
I'm not familiar enough with memory management in C/C++ that I feel
comfortable removing this. Insights would be appreciated.

Reviewed-by: Tom Stellard &lt;thomas.stellard@amd.com&gt;
Reviewed-by: Matt Turner &lt;mattst88@gmail.com&gt;
Signed-off-by: Thomas Helland &lt;thomashelland90@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Only function-defs use glsl_type so forward declare instead.
Compile-tested on my Ivy-bridge system.

IWYU also suggests removing #include &lt;new&gt;, and this compiles fine.
I'm not familiar enough with memory management in C/C++ that I feel
comfortable removing this. Insights would be appreciated.

Reviewed-by: Tom Stellard &lt;thomas.stellard@amd.com&gt;
Reviewed-by: Matt Turner &lt;mattst88@gmail.com&gt;
Signed-off-by: Thomas Helland &lt;thomashelland90@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>glsl: remove {add,get}_type_ast from glsl_symbol_table</title>
<updated>2014-03-28T02:59:49+00:00</updated>
<author>
<name>Chia-I Wu</name>
<email>olvaffe@gmail.com</email>
</author>
<published>2014-03-20T07:45:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/mesa.git/commit/?id=e7f75745984937d004bf3ce08a2a8fd2149801d1'/>
<id>e7f75745984937d004bf3ce08a2a8fd2149801d1</id>
<content type='text'>
They are not needed since 0da1a2cc369052643ccaea75a1722cc37652d82a.

Signed-off-by: Chia-I Wu &lt;olvaffe@gmail.com&gt;
Reviewed-by: Matt Turner &lt;mattst88@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
They are not needed since 0da1a2cc369052643ccaea75a1722cc37652d82a.

Signed-off-by: Chia-I Wu &lt;olvaffe@gmail.com&gt;
Reviewed-by: Matt Turner &lt;mattst88@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>glsl: Make it possible to disable a variable in the symbol table.</title>
<updated>2013-10-10T21:27:27+00:00</updated>
<author>
<name>Paul Berry</name>
<email>stereotype441@gmail.com</email>
</author>
<published>2013-10-01T23:33:56+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/mesa.git/commit/?id=3c83c96dcd1be26e24c07a3dff5df1ef84974901'/>
<id>3c83c96dcd1be26e24c07a3dff5df1ef84974901</id>
<content type='text'>
In later patches, we'll use this in order to implement the required
behaviour that after the gl_PerVertex interface block has been
redeclared, only members of the redeclared interface block may be
used.

v2: Update the function name and comment to clarify that we aren't
actually removing the variable from the symbol table, just disabling
it.

Reviewed-by: Ian Romanick &lt;ian.d.romanick@intel.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In later patches, we'll use this in order to implement the required
behaviour that after the gl_PerVertex interface block has been
redeclared, only members of the redeclared interface block may be
used.

v2: Update the function name and comment to clarify that we aren't
actually removing the variable from the symbol table, just disabling
it.

Reviewed-by: Ian Romanick &lt;ian.d.romanick@intel.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>glsl: Track structs' ast_type_specifiers in symbol table.</title>
<updated>2013-07-12T03:58:59+00:00</updated>
<author>
<name>Matt Turner</name>
<email>mattst88@gmail.com</email>
</author>
<published>2013-06-25T07:27:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/mesa.git/commit/?id=5df807b06f20d53063af9cfc5b4fc867f5fb810a'/>
<id>5df807b06f20d53063af9cfc5b4fc867f5fb810a</id>
<content type='text'>
Will be used in a future commit. An ast_type_specifier is stored (rather
than an ast_struct_specifier) with the idea that we may have more
general uses for this in the future. struct names are prefixed with
'#ast.' to avoid collisions with the glsl_types in the symbol table.

Reviewed-by: Ian Romanick &lt;ian.d.romanick@intel.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Will be used in a future commit. An ast_type_specifier is stored (rather
than an ast_struct_specifier) with the idea that we may have more
general uses for this in the future. struct names are prefixed with
'#ast.' to avoid collisions with the glsl_types in the symbol table.

Reviewed-by: Ian Romanick &lt;ian.d.romanick@intel.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>glsl_symbol_table: add interface block namespaces</title>
<updated>2013-05-23T16:37:12+00:00</updated>
<author>
<name>Jordan Justen</name>
<email>jordan.l.justen@intel.com</email>
</author>
<published>2013-03-21T16:57:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/mesa.git/commit/?id=3919c19468e71fd9590b53e6160db79afb55bfc8'/>
<id>3919c19468e71fd9590b53e6160db79afb55bfc8</id>
<content type='text'>
For interface blocks, there are three separate namespaces for
uniform, input and output blocks.

Signed-off-by: Jordan Justen &lt;jordan.l.justen@intel.com&gt;
Reviewed-by: Kenneth Graunke &lt;kenneth@whitecape.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
For interface blocks, there are three separate namespaces for
uniform, input and output blocks.

Signed-off-by: Jordan Justen &lt;jordan.l.justen@intel.com&gt;
Reviewed-by: Kenneth Graunke &lt;kenneth@whitecape.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>glsl: Track blocks in the symbol table using the glsl_type instead of the gl_uniform_block</title>
<updated>2013-01-25T14:07:34+00:00</updated>
<author>
<name>Ian Romanick</name>
<email>ian.d.romanick@intel.com</email>
</author>
<published>2013-01-22T04:01:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/mesa.git/commit/?id=5383661092fc46cf7013052210e6d624f4d5b596'/>
<id>5383661092fc46cf7013052210e6d624f4d5b596</id>
<content type='text'>
Eventually the gl_uniform_block information won't be calculated until
linking.  Block names need to be checked for name clashes during
compiling, so we have to track it differently.

v2: Update the commit message.  Suggested by Carl Worth.

Signed-off-by: Ian Romanick &lt;ian.d.romanick@intel.com&gt;
Reviewed-by: Kenneth Graunke &lt;kenneth@whitecape.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Eventually the gl_uniform_block information won't be calculated until
linking.  Block names need to be checked for name clashes during
compiling, so we have to track it differently.

v2: Update the commit message.  Suggested by Carl Worth.

Signed-off-by: Ian Romanick &lt;ian.d.romanick@intel.com&gt;
Reviewed-by: Kenneth Graunke &lt;kenneth@whitecape.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>glsl: Track UBO block names in the symbol table.</title>
<updated>2013-01-19T01:35:32+00:00</updated>
<author>
<name>Kenneth Graunke</name>
<email>kenneth@whitecape.org</email>
</author>
<published>2012-11-28T08:18:02+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/mesa.git/commit/?id=4f29169913f99252c54e1922f6d164e2ef530a58'/>
<id>4f29169913f99252c54e1922f6d164e2ef530a58</id>
<content type='text'>
The GLSL 1.40 spec says:

    "Uniform block names and variable names declared within uniform
    blocks are scoped at the program level."

Track the block name in the symbol table and emit errors when conflicts
exist.

Fixes es3conform's uniform_buffer_object_block_name_conflict test, and
fixes the piglit block-name-clashes-with-{variable,function,struct}.vert
tests.

NOTE: This is a candidate for the 9.0 branch.

v2: Fix bad constructor initialization.  Noticed by Topi Pohjolainen.

Reviewed-by: Ian Romanick &lt;ian.d.romanick@intel.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The GLSL 1.40 spec says:

    "Uniform block names and variable names declared within uniform
    blocks are scoped at the program level."

Track the block name in the symbol table and emit errors when conflicts
exist.

Fixes es3conform's uniform_buffer_object_block_name_conflict test, and
fixes the piglit block-name-clashes-with-{variable,function,struct}.vert
tests.

NOTE: This is a candidate for the 9.0 branch.

v2: Fix bad constructor initialization.  Noticed by Topi Pohjolainen.

Reviewed-by: Ian Romanick &lt;ian.d.romanick@intel.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>glsl: Simplify symbol table version checking.</title>
<updated>2012-12-06T20:13:21+00:00</updated>
<author>
<name>Paul Berry</name>
<email>stereotype441@gmail.com</email>
</author>
<published>2012-08-02T00:44:02+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/mesa.git/commit/?id=53e572f15cb394a8d4f2cd5856dd2a06b6ccd3f0'/>
<id>53e572f15cb394a8d4f2cd5856dd2a06b6ccd3f0</id>
<content type='text'>
Previously, we stored the GLSL language version in the
glsl_symbol_table struct.  But this was unnecessary--all
glsl_symbol_table needs to know is whether functions and variables
have separate namespaces (they do in GLSL 1.10 only).

Reviewed-by: Ian Romanick &lt;ian.d.romanick@intel.com&gt;
Reviewed-by: Kenneth Graunke &lt;kenneth@whitecape.org&gt;
Acked-by: Carl Worth &lt;cworth@cworth.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Previously, we stored the GLSL language version in the
glsl_symbol_table struct.  But this was unnecessary--all
glsl_symbol_table needs to know is whether functions and variables
have separate namespaces (they do in GLSL 1.10 only).

Reviewed-by: Ian Romanick &lt;ian.d.romanick@intel.com&gt;
Reviewed-by: Kenneth Graunke &lt;kenneth@whitecape.org&gt;
Acked-by: Carl Worth &lt;cworth@cworth.org&gt;
</pre>
</div>
</content>
</entry>
</feed>
