From fb97b4d691c04d9303571d7eba3cef4a97264e2f Mon Sep 17 00:00:00 2001 From: Doug Ledford Date: Thu, 24 Jul 2008 18:35:11 -0400 Subject: Clean up usage of open() Fix on call that passed an invalid mode to open Don't pass a third arg unless we also pass O_CREAT Use symbolic args for 2nd and 3rd args Signed-off-by: Doug Ledford --- mdopen.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'mdopen.c') diff --git a/mdopen.c b/mdopen.c index 448a9eb..4fbcb48 100644 --- a/mdopen.c +++ b/mdopen.c @@ -173,7 +173,7 @@ int open_mddev(char *dev, int autof) must_remove = 1; if (stb.st_mode && !must_remove) { /* looks ok, see if it is available */ - mdfd = open(dev, O_RDWR, 0); + mdfd = open(dev, O_RDWR); if (mdfd < 0) { fprintf(stderr, Name ": error opening %s: %s\n", dev, strerror(errno)); @@ -254,7 +254,7 @@ int open_mddev(char *dev, int autof) make_parts(dev,parts, ci->symlinks); } } - mdfd = open(dev, O_RDWR, 0); + mdfd = open(dev, O_RDWR); if (mdfd < 0) fprintf(stderr, Name ": error opening %s: %s\n", dev, strerror(errno)); -- cgit v1.2.1