From 5a9df1550f256b7be7aaffbf4cbce13d0ca22566 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vicen=C8=9Biu=20Ciorbaru?= Date: Mon, 12 Oct 2020 13:38:59 +0300 Subject: MDEV-23941: strings/json_lib.c:893:12: style: Suspicious condition The characters parsed are always ascii characters, hence one byte. This means that the code did not have "incorrect" logic because the boolean condition, if true, would also evaluate to the value of 1. The condition however is semantically wrong, assuming a length is equal to the condition outcome. Change paranthesis to make it also read according to the intent. --- strings/json_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'strings') diff --git a/strings/json_lib.c b/strings/json_lib.c index 3ce9b0c503f..3c455c3572c 100644 --- a/strings/json_lib.c +++ b/strings/json_lib.c @@ -890,7 +890,7 @@ int json_read_keyname_chr(json_engine_t *j) case S_QUOTE: for (;;) /* Skip spaces until ':'. */ { - if ((c_len= json_next_char(&j->s) > 0)) + if ((c_len= json_next_char(&j->s)) > 0) { if (j->s.c_next == ':') { -- cgit v1.2.1