From 9c4eb2910bf64871e8f22bbcc3c901515dffaf6b Mon Sep 17 00:00:00 2001 From: Kristofer Pettersson Date: Mon, 18 May 2009 10:10:30 +0200 Subject: Bug#19027 MySQL 5.0 starts even with Fatal InnoDB errors convert_dash_to_underscore was supplied with a character length containing my byte too many which caused valgrind errors of invalid read. --- sql/sql_plugin.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'sql/sql_plugin.cc') diff --git a/sql/sql_plugin.cc b/sql/sql_plugin.cc index b5c7ceda6ab..da168d36429 100644 --- a/sql/sql_plugin.cc +++ b/sql/sql_plugin.cc @@ -3314,7 +3314,7 @@ static int test_plugin_options(MEM_ROOT *tmp_root, struct st_plugin_int *tmp, varname= (char*) alloc_root(mem_root, len); strxmov(varname, tmp->name.str, "-", o->name, NullS); my_casedn_str(&my_charset_latin1, varname); - convert_dash_to_underscore(varname, len); + convert_dash_to_underscore(varname, len-1); v= new (mem_root) sys_var_pluginvar(varname, o); } DBUG_ASSERT(v); /* check that an object was actually constructed */ -- cgit v1.2.1