From befacafd73d4892f2ad84991ad7c2d4626e45c47 Mon Sep 17 00:00:00 2001 From: Sergey Petrunya Date: Thu, 27 Jun 2013 17:56:49 +0400 Subject: [SHOW] EXPLAIN UPDATE/DELETE, code re-structuring - Let Query Plan Footprint store join buffer type in binary form, not string. - Same for LooseScan type. --- sql/sql_join_cache.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'sql/sql_join_cache.h') diff --git a/sql/sql_join_cache.h b/sql/sql_join_cache.h index 6953f6881ee..75589c3395f 100644 --- a/sql/sql_join_cache.h +++ b/sql/sql_join_cache.h @@ -63,6 +63,7 @@ typedef struct st_cache_field { class JOIN_TAB_SCAN; +struct st_qpf_bka_type; /* JOIN_CACHE is the base class to support the implementations of @@ -657,7 +658,7 @@ public: enum_nested_loop_state join_records(bool skip_last); /* Add a comment on the join algorithm employed by the join cache */ - virtual void print_explain_comment(String *str); + virtual void save_qpf(struct st_qpf_bka_type *qpf); THD *thd(); @@ -1335,7 +1336,7 @@ public: /* Check index condition of the joined table for a record from BKA cache */ bool skip_index_tuple(range_id_t range_info); - void print_explain_comment(String *str); + void save_qpf(struct st_qpf_bka_type *qpf); }; @@ -1426,5 +1427,5 @@ public: /* Check index condition of the joined table for a record from BKAH cache */ bool skip_index_tuple(range_id_t range_info); - void print_explain_comment(String *str); + void save_qpf(struct st_qpf_bka_type *qpf); }; -- cgit v1.2.1 From fedf769f0b2001f8294c2b44dbcaca1e562f82a9 Mon Sep 17 00:00:00 2001 From: Sergey Petrunya Date: Sat, 5 Oct 2013 09:58:22 +0400 Subject: MDEV-3798: EXPLAIN UPDATE/DELETE - Address review feedback: rename nearly any name used by the new EXPLAIN code. --- sql/sql_join_cache.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'sql/sql_join_cache.h') diff --git a/sql/sql_join_cache.h b/sql/sql_join_cache.h index 75589c3395f..0b03f2b8bab 100644 --- a/sql/sql_join_cache.h +++ b/sql/sql_join_cache.h @@ -63,7 +63,7 @@ typedef struct st_cache_field { class JOIN_TAB_SCAN; -struct st_qpf_bka_type; +struct st_explain_bka_type; /* JOIN_CACHE is the base class to support the implementations of @@ -658,7 +658,7 @@ public: enum_nested_loop_state join_records(bool skip_last); /* Add a comment on the join algorithm employed by the join cache */ - virtual void save_qpf(struct st_qpf_bka_type *qpf); + virtual void save_explain_data(struct st_explain_bka_type *qpf); THD *thd(); @@ -1336,7 +1336,7 @@ public: /* Check index condition of the joined table for a record from BKA cache */ bool skip_index_tuple(range_id_t range_info); - void save_qpf(struct st_qpf_bka_type *qpf); + void save_explain_data(struct st_explain_bka_type *qpf); }; @@ -1427,5 +1427,5 @@ public: /* Check index condition of the joined table for a record from BKAH cache */ bool skip_index_tuple(range_id_t range_info); - void save_qpf(struct st_qpf_bka_type *qpf); + void save_explain_data(struct st_explain_bka_type *qpf); }; -- cgit v1.2.1 From 72bc6d7364f7cf6cae49c74cf1e56832053f91eb Mon Sep 17 00:00:00 2001 From: Sergey Petrunya Date: Sat, 5 Oct 2013 13:19:45 +0400 Subject: MDEV-3798: EXPLAIN UPDATE/DELETE - Address review feedback: more renames --- sql/sql_join_cache.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'sql/sql_join_cache.h') diff --git a/sql/sql_join_cache.h b/sql/sql_join_cache.h index 0b03f2b8bab..9dae7fb24e0 100644 --- a/sql/sql_join_cache.h +++ b/sql/sql_join_cache.h @@ -658,7 +658,7 @@ public: enum_nested_loop_state join_records(bool skip_last); /* Add a comment on the join algorithm employed by the join cache */ - virtual void save_explain_data(struct st_explain_bka_type *qpf); + virtual void save_explain_data(struct st_explain_bka_type *explain); THD *thd(); @@ -1336,7 +1336,7 @@ public: /* Check index condition of the joined table for a record from BKA cache */ bool skip_index_tuple(range_id_t range_info); - void save_explain_data(struct st_explain_bka_type *qpf); + void save_explain_data(struct st_explain_bka_type *explain); }; @@ -1427,5 +1427,5 @@ public: /* Check index condition of the joined table for a record from BKAH cache */ bool skip_index_tuple(range_id_t range_info); - void save_explain_data(struct st_explain_bka_type *qpf); + void save_explain_data(struct st_explain_bka_type *explain); }; -- cgit v1.2.1