From 3950b70336bf722af5a41c7a73b3f44f13d8a38a Mon Sep 17 00:00:00 2001 From: unknown Date: Mon, 26 May 2003 20:48:40 +0300 Subject: ixed wrong unlock of tables (new bug) sql/sql_delete.cc: Comment cleanup sql/sql_insert.cc: Comment cleanup sql/sql_load.cc: Comment cleanup sql/sql_update.cc: Fixed wrong unlock of tables. (Unlock must be done after writing to binary log --- sql/sql_insert.cc | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) (limited to 'sql/sql_insert.cc') diff --git a/sql/sql_insert.cc b/sql/sql_insert.cc index 48cc6d4e254..1908f898a27 100644 --- a/sql/sql_insert.cc +++ b/sql/sql_insert.cc @@ -350,9 +350,7 @@ int mysql_insert(THD *thd,TABLE_LIST *table_list, before binlog writing and ha_autocommit_... */ if (info.copied || info.deleted) - { query_cache_invalidate3(thd, table_list, 1); - } transactional_table= table->file->has_transactions(); @@ -1424,9 +1422,7 @@ void select_insert::send_error(uint errcode,const char *err) table->file->extra(HA_EXTRA_NO_CACHE); table->file->activate_all_index(thd); if (info.copied || info.deleted) - { query_cache_invalidate3(thd, table, 1); - } ha_rollback_stmt(thd); } @@ -1438,13 +1434,13 @@ bool select_insert::send_eof() error=table->file->activate_all_index(thd); table->file->extra(HA_EXTRA_NO_IGNORE_DUP_KEY); - /* We must invalidate the table in the query cache before binlog writing - and ha_autocommit_... */ + /* + We must invalidate the table in the query cache before binlog writing + and ha_autocommit_... + */ if (info.copied || info.deleted) - { query_cache_invalidate3(thd, table, 1); - } /* Write to binlog before commiting transaction */ if (mysql_bin_log.is_open()) -- cgit v1.2.1