From dae4fb0acb373e653f826f0ec7bdaf2485ef0b93 Mon Sep 17 00:00:00 2001 From: Alexander Barkov Date: Tue, 30 Jan 2018 11:07:35 +0400 Subject: MDEV-15118 ExtractValue(xml,something_complex) does not work Item_xml_str_func::fix_fields() used a local "String tmp" as a buffer for args[1]->val_str(). "tmp" was freed at the end of fix_fields(), while Items created during my_xpath_parse() still pointed to its fragments. Adding a new member Item_xml_str_func::m_xpath_query and store the result of args[1]->val_str() into it. --- sql/item_xmlfunc.h | 1 + 1 file changed, 1 insertion(+) (limited to 'sql/item_xmlfunc.h') diff --git a/sql/item_xmlfunc.h b/sql/item_xmlfunc.h index 637f505e12e..e0356d367bd 100644 --- a/sql/item_xmlfunc.h +++ b/sql/item_xmlfunc.h @@ -67,6 +67,7 @@ protected: return parse(res, cache); } }; + String m_xpath_query; // XPath query text Item *nodeset_func; XML xml; bool get_xml(XML *xml, bool cache= false) -- cgit v1.2.1