From bf9bb656a65c18eb15ee475e5f58412c859ef76a Mon Sep 17 00:00:00 2001 From: unknown Date: Tue, 26 Feb 2008 12:03:59 -0300 Subject: Bug#34424 query_cache_debug.test leads to valgrind warnings Bug#34678 @@debug variable's incremental mode The problem is that the per-thread debugging settings stack wasn't being deallocated before the thread termination, leaking the stack memory. The chosen solution is to push a new state if the current is set to the initial settings and pop it (free) once the thread finishes. dbug/dbug.c: Move dbug parser out of _db_set_ to a separate function and make _db_set_ push a new stack if the corrent one is set to the initial settings. dbug/user.r: Update DBUG_SET description. mysql-test/t/disabled.def: Re-enable test case which triggered the leak. mysys/my_thr_init.c: Pop a pushed state, nop if stack is empty. sql/set_var.cc: Handle incremental debug settings. mysql-test/r/variables_debug.result: Add new test case result for Bug#34678 mysql-test/t/variables_debug.test: Add new test case for Bug#34678 --- mysql-test/r/variables_debug.result | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 mysql-test/r/variables_debug.result (limited to 'mysql-test/r/variables_debug.result') diff --git a/mysql-test/r/variables_debug.result b/mysql-test/r/variables_debug.result new file mode 100644 index 00000000000..9cd133dddb1 --- /dev/null +++ b/mysql-test/r/variables_debug.result @@ -0,0 +1,12 @@ +set debug= 'T'; +select @@debug; +@@debug +T +set debug= '+P'; +select @@debug; +@@debug +P:T +set debug= '-P'; +select @@debug; +@@debug +T -- cgit v1.2.1