summaryrefslogtreecommitdiff
path: root/sql
diff options
context:
space:
mode:
authorMarko Mäkelä <marko.makela@mariadb.com>2019-02-15 12:30:43 +0200
committerMarko Mäkelä <marko.makela@mariadb.com>2019-02-15 12:30:43 +0200
commit2b921845ac5ba54da607e781e63d345be83b98b1 (patch)
treeb9df456d60f5e7e059fda3364fbf7ded46804109 /sql
parentdcaabf07fdfb608fe3e6485e392bc10757891ad2 (diff)
parente8b6c15010e6fffe17e27c165b8c60b51a8f66a7 (diff)
downloadmariadb-git-2b921845ac5ba54da607e781e63d345be83b98b1.tar.gz
Merge 10.3 into 10.4
Diffstat (limited to 'sql')
-rw-r--r--sql/item_func.cc11
1 files changed, 5 insertions, 6 deletions
diff --git a/sql/item_func.cc b/sql/item_func.cc
index a10f381b1dc..ef0dc0ba34b 100644
--- a/sql/item_func.cc
+++ b/sql/item_func.cc
@@ -6330,17 +6330,17 @@ Item_func_sp::fix_fields(THD *thd, Item **ref)
if (m_sp->agg_type() == GROUP_AGGREGATE)
{
- List<Item> list;
- list.empty();
- for (uint i=0; i < arg_count; i++)
- list.push_back(*(args+i));
-
Item_sum_sp *item_sp;
Query_arena *arena, backup;
arena= thd->activate_stmt_arena_if_needed(&backup);
if (arg_count)
+ {
+ List<Item> list;
+ for (uint i= 0; i < arg_count; i++)
+ list.push_back(args[i]);
item_sp= new (thd->mem_root) Item_sum_sp(thd, context, m_name, sp, list);
+ }
else
item_sp= new (thd->mem_root) Item_sum_sp(thd, context, m_name, sp);
@@ -6354,7 +6354,6 @@ Item_func_sp::fix_fields(THD *thd, Item **ref)
if (err)
DBUG_RETURN(TRUE);
- list.empty();
DBUG_RETURN(FALSE);
}