delta/libvirt.git/tests/qemublocktestdata/bitmapblockcommit, branch master

qemu: block: Remove 'active-write' bitmap even if there are no bitmaps to merge

2020-07-21T07:52:59+00:00

The 'libvirt-tmp-activewrite' bitmap is added during the 'pivot'
operation of block copy and active layer block commit operations
regardless of whether there are any bitmaps to merge, but was not
removed unless a bitmap was merged. This meant that subsequent attempts
to merge into the same image would fail.

Fix it by checking whether the 'libvirt-tmp-activewrite' would be used
by the code and don't skip the code which would delete it.

This is a regression introduced when we switched to the new code for
block commit in <20a7abc2d2d> and for block copy in <7bfff40fdfe5>. The
actual bug originates from <4fa8654ece>.

https://bugzilla.redhat.com/show_bug.cgi?id=1857735

Signed-off-by: Peter Krempa 
Reviewed-by: Eric Blake

qemublocktest: Add 'snapshots' tests for block commit bitmap handling

2020-06-22T14:04:31+00:00

Simulate commit between all the combinations of layers in the
'snapshots' case to see whether the code merges the correct bitmaps with
the correct depth of temporary bitmaps.

Signed-off-by: Peter Krempa 
Reviewed-by: Eric Blake

qemublocktest: Add 'basic' tests for commit bitmap handling

2020-06-22T14:04:30+00:00

In the 'basic' case we have few bitmaps in only the top layer. Simulate
commit into the backing of the top layer and also 2 levels deep.

Signed-off-by: Peter Krempa 
Reviewed-by: Eric Blake

qemu: Rewrite bitmap handling for block commit

2020-06-22T14:04:30+00:00

Reuse qemuBlockGetBitmapMergeActions which allows removing the ad-hoc
implementation of bitmap merging for block commit. The new approach is
way simpler and more robust and also allows us to get rid of the
disabling of bitmaps done prior to the start as we actually do want to
update the bitmaps in the base.

Signed-off-by: Peter Krempa 
Reviewed-by: Eric Blake

qemublocktest: Disable testcases for all bitmap handling

2020-06-22T14:04:30+00:00

Upcoming patches are going to rewrite and semantically modify how
bitmaps are handled during blockjobs. This is possible as incremental
backup is not yet fully enabled.

As the changes are going to be incompatible with any current test data
remove all test cases for bitmap handling during checkpoint deletion,
incremental backups, block commit, block copy, and bitmap validation
operations.

The tests will be gradually added back later after the code and
test-data is refactored.

Signed-off-by: Peter Krempa 
Reviewed-by: Eric Blake

qemublocktest: Add 'empty' case for checkpoint bitmap handling

2020-06-22T14:04:29+00:00

Signed-off-by: Peter Krempa 
Reviewed-by: Eric Blake

qemublocktest: Add tests for re-enabling of bitmaps after commit

2020-03-17T15:32:13+00:00

Some branches were not covered and thus we didn't catch that the bitmaps
are not re-enabled if nothing is merged into them. Two bitmaps are
necessary to reliably test the case due to hash table ordering.

Signed-off-by: Peter Krempa 
Reviewed-by: Ján Tomko 
Reviewed-by: Daniel P. Berrangé 
Tested-by: Daniel P. Berrangé

qemublocktest: Add tests of broken bitmap chain handling during block-commit

2020-03-16T16:33:08+00:00

Use the 'snapshots-synthetic-broken' test data for block-commit.

Signed-off-by: Peter Krempa 
Reviewed-by: Eric Blake

qemublocktest: Add more tests for block-commit bitmap handling with snapshots

2020-03-16T16:33:08+00:00

Test handling of more complex cases of merging bitmaps accross
snapshots.

Signed-off-by: Peter Krempa 
Reviewed-by: Eric Blake

qemublocktest: Add tests for handling of bitmaps during block-commit

2020-03-16T16:33:08+00:00

Add code for testing the two necessary steps of handling bitmaps during
block commit and exercise the code on the test data which we have for
bitmap handling.

Signed-off-by: Peter Krempa 
Reviewed-by: Eric Blake