delta/libvirt.git/src, branch master

conf: numa: Allow formatting 'none' values for 'associativity' and 'policy' of cache

2023-05-17T08:07:18+00:00

The parser makes the values mandatory and also the qemu code implements
actions for those values. The formatter skips them though. Since
format+parse is used to copy the XML at startup a definition with those
values can't be started.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2203709
Signed-off-by: Peter Krempa 
Reviewed-by: Michal Privoznik

virDomainNumaDefNodeCacheParseXML: Refactor parsing of cache XML

2023-05-17T08:07:18+00:00

Use virXMLProp* helpers to simplify the code.

Signed-off-by: Peter Krempa 
Reviewed-by: Michal Privoznik

qemu: Generate command line for MTE feature

2023-05-16T15:43:05+00:00

This is pretty trivial, just append "mte=on/off" to -machine
arguments.

Signed-off-by: Michal Privoznik 
Reviewed-by: Martin Kletzander

qemu: Validate MTE feature

2023-05-16T15:43:03+00:00

The MTE feature is not supported by all QEMUs, only those with
QEMU_CAPS_MACHINE_VIRT_MTE capability.

Signed-off-by: Michal Privoznik 
Reviewed-by: Martin Kletzander

qemu:: Introduce QEMU_CAPS_MACHINE_VIRT_MTE capability

2023-05-16T15:43:00+00:00

The MTE feature (introduced in QEMU commit of v5.1.0-rc1~8^2~11)
is detectable via 'qom-list-properties' for 'virt' machine type.

Signed-off-by: Michal Privoznik 
Reviewed-by: Martin Kletzander

conf: Introduce MTE domain feature

2023-05-16T15:42:58+00:00

The Memory Tagging Extensions are hardware acceleration present
in some ARM processors that allow memory error detection [1].
Introduce a domain XML knob that turns them on or off.

1: https://www.arm.com/blogs/blueprint/memory-safety-arm-memory-tagging-extension
Signed-off-by: Michal Privoznik 
Reviewed-by: Martin Kletzander

qemu: Drop @forceVFIO argument of qemuDomainGetMemLockLimitBytes()

2023-05-16T12:43:43+00:00

After previous cleanup, there's not a single caller that would
call qemuDomainGetMemLockLimitBytes() with @forceVFIO set. All
callers pass false.

Drop the unneeded argument from the function.

Signed-off-by: Michal Privoznik 
Reviewed-by: Martin Kletzander

qemu: Drop @forceVFIO argument of qemuDomainAdjustMaxMemLock()

2023-05-16T12:43:43+00:00

After previous cleanup, there's not a single caller that would
call qemuDomainAdjustMaxMemLock() with @forceVFIO set. All callers
pass false.

Drop the unneeded argument from the function.

Signed-off-by: Michal Privoznik 
Reviewed-by: Martin Kletzander

qemu_domin: Account for NVMe disks when calculating memlock limit on hotplug

2023-05-16T12:43:42+00:00

During hotplug of a NVMe disk we need to adjust the memlock
limit. The computation of the limit is handled by
qemuDomainGetMemLockLimitBytes() which looks at given domain
definition and accounts for various device types (as different
types require different amounts). But during disk hotplug the
disk is not added to domain definition until the very last
moment. Therefore, qemuDomainGetMemLockLimitBytes() has this
@forceVFIO argument which tells it to assume VFIO even if there
are no signs of VFIO in domain definition. And this kind of
works, until the amount needed for NVMe disks changed (in
v9.3.0-rc1~52). What's missing in the commit is making @forceVFIO
behave the same as if there was an NVMe disk present in the
domain definition.

But, we can do even better - just mimic whatever we're doing for
hostdevs. IOW - introduce qemuDomainAdjustMaxMemLockNVMe() that
behaves the same as qemuDomainAdjustMaxMemLockHostdev().

There are subtle differences though:

1) qemuDomainAdjustMaxMemLockHostdev() can afford placing hostdev
   right at the end of vm->def->hostdevs, because the array was
   already reallocated (at the beginning of
   qemuDomainAttachHostPCIDevice()). But
   qemuDomainAdjustMaxMemLockNVMe() doesn't have that luxury.

2) qemuDomainAdjustMaxMemLockHostdev() places a
   virDomainHostdevDef pointer into domain definition, while
   qemuDomainStorageSourceAccessModifyNVMe() (which calls
   qemuDomainAdjustMaxMemLock()) sees a virStorageSource pointer
   but domain definition contains virDomainDiskDef. But that's
   okay, we can create a dummy disk definition and append it into
   the domain definition.

After this, qemuDomainAdjustMaxMemLock() can be called with
@forceVFIO = false, as the disk is now part of domain definition
(when computing the new limit).

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2014030#c28
Signed-off-by: Michal Privoznik 
Reviewed-by: Martin Kletzander

schemas: backup: Allow missing 'type' attribute for backup disk

2023-05-16T08:26:33+00:00

One of our examples in the 'formatbackup.rst' page shows following
config:

  

The schema didn't allow it though. Fix the schema as the internals were
supposed to support it (except for the bug fixed in previous patches).

Signed-off-by: Peter Krempa 
Reviewed-by: Ján Tomko