delta/libvirt.git/src/node_device, branch master

meson: Use initconfdir

2023-05-05T13:08:25+00:00

Signed-off-by: Andrea Bolognani 
Reviewed-by: Martin Kletzander

node_device: Update format strings in translated messages

2023-04-01T09:40:33+00:00

Signed-off-by: Jiri Denemark 
Reviewed-by: Daniel P. Berrangé

util: remove waitForLock from virPidFileAcquire

2023-03-08T11:16:55+00:00

The parameter was added for consistency with virPidFileAcquirePath.
However, all callers of virPidFileAcquire pass false.

Remove the argument.

Partially-reverts: 2250a2b5d21c3b3529727f38a99cba22f84024f7
Signed-off-by: Ján Tomko 
Reviewed-by: Martin Kletzander

nodedev: ignore EINVAL from libudev in udevEventHandleThread

2022-11-10T10:50:22+00:00

Certain udev entries might be of a size that makes libudev emit EINVAL
which right now leads to udevEventHandleThread exiting. Due to no more
handling events other elements of libvirt will start pushing for events
to be consumed which never happens causing a busy loop burning a cpu
without any gain.

After evaluation of the example case discussed in in #245 and a test
run ignoring EINVAL it was considered safe to add EINVAL to the ignored
errnos to not exit udevEventHandleThread giving it more resilience.

The root cause is in systemd and by now was discussed and fixed via
https://github.com/systemd/systemd/issues/24987, but hardening libvirt
to be able to better deal with EINVAL returned still is the right thing
to avoid the reported busy loops on systemd with older systemd versions.

Fixes: https://gitlab.com/libvirt/libvirt/-/issues/245

Signed-off-by: Christian Ehrhardt 
Reviewed-by: Daniel P. Berrangé

nodedev|test: Implement support for validating node device XMLs

2022-11-01T12:07:20+00:00

Signed-off-by: Peter Krempa 
Reviewed-by: Jonathon Jongsma

conf: node_device: Add 'validate' argument to virNodeDeviceDefParse

2022-11-01T12:07:20+00:00

Allow callers to request XML validation against the schema. All callers
for now pass 'false'.

Signed-off-by: Peter Krempa 
Reviewed-by: Jonathon Jongsma

node_device_driver.h: Drop nodeDeviceLock() and nodeDeviceUnlock() fwd declarations

2022-10-26T06:49:01+00:00

The node_device_driver.h declares nodeDeviceLock() and
nodeDeviceUnlock() functions which used to exist, but after
rework to automatic mutex management they exist no more. Their
last use was removed in v8.1.0-rc1~122.

Signed-off-by: Michal Privoznik 
Reviewed-by: Jonathon Jongsma

node_device: Move fwd declaration of udevNodeRegister() into correct header file

2022-10-26T06:48:23+00:00

Currently, udevNodeRegister() is forward declared in
node_device_driver.h even though the function is implemented in
node_device_udev.c which warrants node_device_udev.h header file.
Move the declaration into the correct file.

Signed-off-by: Michal Privoznik 
Reviewed-by: Jonathon Jongsma

node_device_udev.h: Drop include of libudev.h

2022-10-26T06:47:59+00:00

Nothing in the header file requires the include of libudev.h, as
the former header file is now empty.

Signed-off-by: Michal Privoznik 
Reviewed-by: Jonathon Jongsma

node_device: Move DMI_DEVPATH into node_device_udev.c

2022-10-26T06:47:32+00:00

The DMI_DEVPATH macro is used exclusively within
node_device_udev.c. There's no need to expose it.

Signed-off-by: Michal Privoznik 
Reviewed-by: Jonathon Jongsma