delta/libvirt-python.git/libvirt-utils.c, branch v9.3.0

libvirt-utils: Clear error when guessing typed param type

2022-07-08T06:21:58+00:00

Our APIs which accept typed parameters are usually exposed in
python as accepting dictionary, for instance:

  virDomainSetIOThreadParams(..., virTypedParameterPtr params, ...) ->
  virDomain.setIOThreadParams(..., {}, ...)

Now, before calling the C API, the dictionary is processed by
virPyDictToTypedParams() which accepts an additional argument:
array that hints types for each typed parameter. However, if a
key is not in the array we guess what the correct type might be.
This is done by attempting conversion from python into string, if
that fails then into boolean, then into long, only to fall back
to double. Now, for the long type we can have two cases: the
value is non-negative (ULL) or it is negative (LL). Therefore, we
firstly attempt ULL case and if that fails we stick with the
latter.

However, after we attempted the ULL conversion, python records an
error internally (which is then queried via PyErr_Occurred()),
but the error is never cleared out. This leads to spurious paths
taken afterwards: e.g. when libvirt_longlongUnwrap() is trying to
convert -1, it fails. But not rightfully - the PyErr_Occurred()
check it performs has nothing to do with any of its actions,
rather than our guessing work done before.

Therefore, clear the error after we've guessed the type.

Signed-off-by: Michal Privoznik

Drop support for python 2

2019-12-04T12:14:51+00:00

python2 will be end of life by the time of the next
libvirt release. All our supported build targets, including
CentOS7, have a python3 build available.

Reviewed-by: Michal Privoznik 
Signed-off-by: Daniel P. Berrangé

libvirt_charPtrUnwrap: remove unnecessary check of returned string

2018-06-12T08:27:38+00:00

Function libvirt_charPtrUnwrap() either fails or always sets the
unwrapped string so there is no need to check it explicitly.

Reviewed-by: Ján Tomko 
Signed-off-by: Pavel Hrdina

libvirt-utils: remove unused py_str function

2018-06-12T08:27:14+00:00

Commit <57a160b5248ba47d4e1c9d22d95847dad8e0524f> removed last usage
but did not remove the function itself.

Reviewed-by: Ján Tomko 
Signed-off-by: Pavel Hrdina

Avoid implicit treatment of an arithmetic result as a boolean

2017-09-26T10:14:03+00:00

Latest GCC versions are unhappy with us treating an integer
arithmetic result as a boolean:

libvirt-utils.c: In function ‘virReallocN’:
libvirt-utils.c:111:23: warning: ‘*’ in boolean context, suggest ‘&&’ instead [-Wint-in-bool-context]
     if (!tmp && (size * count)) {
                 ~~~~~~^~~~~~~~

Add an explicit comparison '!= 0' to keep it happy, since its
suggestion to use '&&' is nonsense.

Signed-off-by: Daniel P. Berrange

Fix comparisons between signed & unsigned integers

2017-09-26T10:12:18+00:00

When python3 builds C modules, it adds the -Wsign-compare flag to GCC.
This creates lots of warnings where we compare a 'size_t' value against
an 'int' value due to signed/unsigned difference.  Change all the size_t
types to ssize_t to address this.

Signed-off-by: Daniel P. Berrange

don't overrun buffer when converting cpumap

2016-11-11T13:02:24+00:00

If we pass large(more than cpunum) cpu mask to any libvirt_virDomainPin*
function, it could leads to crash. So we have to check tuple size in
virPyCpumapConvert and ignore extra tuple members.

Since we allocate a zeroed buffer, we don't need to bother with setting
the bits to zero.

Signed-off-by: Konstantin Neumoin

move cpumap conversion code to a common helper

2016-11-11T12:44:44+00:00

All libvirt_virDomainPin* functions do the same thing for convert
pycpumap to cpumap, so this patch moves all common logic to new
helper - virPyCpumapConvert.

Signed-off-by: Konstantin Neumoin

use VIR_PY_DICT_SET_GOTO

2015-10-05T07:42:44+00:00

Signed-off-by: Pavel Hrdina

indent labels by one space

2015-10-05T06:35:30+00:00

Signed-off-by: Pavel Hrdina