delta/libvirt-python.git, branch v7.3.0

generator.py: Untangle virNodeDevice name fixup

2021-04-15T11:12:53+00:00

The way that virNodeDevice method name fixup is written makes it
hard to find via grep (matching the virNodeDevice prefix and then
matching only the operation like "Get", "Lookup", ...). Expand
the string matching to match the pattern of other cases.

Signed-off-by: Michal Privoznik

generator.py: Fix method names for new virNodeDevice*() APIs

2021-04-15T11:12:29+00:00

In the 7.3.0 release we are going to have three new public APIs:

  virNodeDeviceDefineXML()
  virNodeDeviceUndefine()
  virNodeDeviceCreate()

The first one is slightly problematic, because it takes
virConnectPtr argument and thus our generator wants to put its
wrapper under virConnect python class, which is correct, but
what's incorrect is the name it chooses for the method:
defineXML(). Such method already exists and wraps
virDomainDefineXML() around. Also, the name is rather confusing
anyway - it's missing the 'nodeDevice' prefix.

Fortunately, the fix is easy - add another case into nameFixup().

The story with virNodeDeviceCreate() is similar. Except, this time
the class in which the method was put is correct. But the name is
still wrong, because our generator matched 'virNodeDeviceCreate'
thinking it's the good old virNodeDeviceCreateXML() API and
"fixed" the name of the method to nodeDeviceCreate().

Luckily, virNodeDeviceUndefine() is just fine.

Signed-off-by: Michal Privoznik

spec: use pytest instead of nose

2021-04-12T17:39:22+00:00

Signed-off-by: Ján Tomko

rpm: use HTTPS for URLs

2021-04-12T17:12:48+00:00

Signed-off-by: Daniel P. Berrangé

Don't run sanity checks by default

2021-04-09T15:40:42+00:00

The sanity check scripts verify that the binding covers all APIs in the
libvirt library/headers being built against. This is primarily there for
libvirt maintainers to identify when there are gaps in API coverage.

This is not something downstream consumers of libvirt-python should be
running themselves, so we shouldn't added it to tests by default.

In addition if people are working on branches or submitting merge
requests for python changes, we shouldn't block their work for failed
API coverage sanity tests, if the python binding otherwise builds fine
and passes regular unit tests.

Thus, we introduce a new gitlab job "api-coverage" with some conditions:

 - If pushing to a branch, the job is treated as non-fatal
 - For regular scheduled builds, it is mandatory
 - Don't run in any other scenarios

This job uses the artifacts from the centos-8-git-build job and re-runs
the test suite, requesting the sanity tests to be run too.

This will achieve the result of letting us see missing API coverage
in nightly builds, without blocking other contributions.

Signed-off-by: Daniel P. Berrangé

tests: use assertEqual instead of assertEquals

2021-04-07T15:10:36+00:00

tests/test_conn.py:17: DeprecationWarning: Please use assertEqual instead.

Signed-off-by: Ján Tomko

ci: refresh containers for nose->pytest switch

2021-04-07T15:10:36+00:00

Matches libvirt-ci commit facd5d855c97bf5b127ff9bf245c8fdf514dd916

Signed-off-by: Ján Tomko

setup: use pytest instead of nose to run the test suite

2021-04-07T15:09:54+00:00

The software we use for running tests - nose - has been
deprecated in favor of nose2.

We don't use anything nose-specific, just unittest.TestCase,
which pytest can handle just fine.

Switch to using pytest, which we already use for libvirt-dbus.

Signed-off-by: Ján Tomko

setup: drop have_libvirtaio

2021-04-07T14:25:45+00:00

This function says we have libvirtaio on Python >= 3.3,
however we already mandate Python >= 3.5 at the start of the file.

Signed-off-by: Ján Tomko

ci: Move dco job to sanity_checks stage

2021-04-07T11:56:24+00:00

If the DCO check fails we still want the pipeline to fail, but
that doesn't mean there's no value in running the other jobs to
get a better picture.

Signed-off-by: Andrea Bolognani