From a3a33b0e1c3af75f1a18e6563d24dfeaf9c3c7bd Mon Sep 17 00:00:00 2001 From: Dan Winship Date: Mon, 22 Aug 2005 17:00:18 +0000 Subject: Fix g_object_add/remove_weak_pointer usage to prevent a crash when * libsoup/soup-connection.c (set_current_request, clear_current_request): Fix g_object_add/remove_weak_pointer usage to prevent a crash when canceling a request. From Tambet. --- ChangeLog | 6 ++++++ libsoup/soup-connection.c | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 5f5a113b..b41345eb 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2005-08-22 Dan Winship + + * libsoup/soup-connection.c (set_current_request, + clear_current_request): Fix g_object_add/remove_weak_pointer usage + to prevent a crash when canceling a request. From Tambet. + 2005-08-18 Harish Krishnaswamy * libsoup/soup-socket.c (finalize) : fix for an error in diff --git a/libsoup/soup-connection.c b/libsoup/soup-connection.c index 88ede8aa..feae2b4b 100644 --- a/libsoup/soup-connection.c +++ b/libsoup/soup-connection.c @@ -312,7 +312,7 @@ set_current_request (SoupConnection *conn, SoupMessage *req) conn->priv->cur_req = req; conn->priv->in_use = TRUE; g_object_add_weak_pointer (G_OBJECT (req), - (gpointer *)conn->priv->cur_req); + (gpointer *)&conn->priv->cur_req); } static void @@ -325,7 +325,7 @@ clear_current_request (SoupConnection *conn) conn->priv->last_used = time (NULL); g_object_remove_weak_pointer (G_OBJECT (conn->priv->cur_req), - (gpointer *)conn->priv->cur_req); + (gpointer *)&conn->priv->cur_req); conn->priv->cur_req = NULL; } conn->priv->in_use = FALSE; -- cgit v1.2.1