diff options
| author | Dan Winship <danw@src.gnome.org> | 2006-06-08 12:40:19 +0000 |
|---|---|---|
| committer | Dan Winship <danw@src.gnome.org> | 2006-06-08 12:40:19 +0000 |
| commit | 6b07580dad1eff4f8b5732aa4f3230c24fd04ba2 (patch) | |
| tree | 92aac2a208f7c70efdc7598a71ee56276910fc44 | |
| parent | e079cb161ee2523c6694d4970943690d78bfa07e (diff) | |
| download | libsoup-6b07580dad1eff4f8b5732aa4f3230c24fd04ba2.tar.gz | |
Check return value of strtol/g_ascii_strtod correctly. #344222, patch from
* libsoup/soup-xmlrpc-response.c (soup_xmlrpc_value_get_int,
soup_xmlrpc_value_get_double, soup_xmlrpc_value_get_boolean):
Check return value of strtol/g_ascii_strtod correctly. #344222,
patch from Brent Smith.
| -rw-r--r-- | ChangeLog | 7 | ||||
| -rw-r--r-- | libsoup/soup-xmlrpc-response.c | 6 |
2 files changed, 10 insertions, 3 deletions
@@ -1,3 +1,10 @@ +2006-06-08 Dan Winship <danw@novell.com> + + * libsoup/soup-xmlrpc-response.c (soup_xmlrpc_value_get_int, + soup_xmlrpc_value_get_double, soup_xmlrpc_value_get_boolean): + Check return value of strtol/g_ascii_strtod correctly. #344222, + patch from Brent Smith. + 2006-06-07 Dan Winship <danw@novell.com> * libsoup/soup-xmlrpc-response.c diff --git a/libsoup/soup-xmlrpc-response.c b/libsoup/soup-xmlrpc-response.c index 891cb827..98eb9648 100644 --- a/libsoup/soup-xmlrpc-response.c +++ b/libsoup/soup-xmlrpc-response.c @@ -253,7 +253,7 @@ soup_xmlrpc_value_get_int (SoupXmlrpcValue *value, long *i) *i = strtol ((char *)content, &tail, 10); xmlFree (content); - if (tail != '\0') + if (*tail != '\0') return FALSE; else return TRUE; @@ -279,7 +279,7 @@ soup_xmlrpc_value_get_double (SoupXmlrpcValue *value, double *b) *b = g_ascii_strtod ((char *)content, &tail); xmlFree (content); - if (tail != '\0') + if (*tail != '\0') return FALSE; else return TRUE; @@ -305,7 +305,7 @@ soup_xmlrpc_value_get_boolean (SoupXmlrpcValue *value, gboolean *b) i = strtol ((char *)content, &tail, 10); xmlFree (content); - if (tail != '\0') + if (*tail != '\0') return FALSE; if (i != 0 && i != 1) |