From 91e2837c1128f0ee39cbb8dce0dd120ff21d1785 Mon Sep 17 00:00:00 2001 From: Tomas Mraz Date: Mon, 24 Aug 2015 16:20:08 +0200 Subject: Fix possible stack overflow in pwquality_generate() with data from /dev/urandom. --- src/generate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/generate.c b/src/generate.c index 0b83b97..3d22491 100644 --- a/src/generate.c +++ b/src/generate.c @@ -100,7 +100,7 @@ consume_entropy(char *buf, int bits, int *remaining, int *offset) int pwquality_generate(pwquality_settings_t *pwq, int entropy_bits, char **password) { - char entropy[PWQ_MAX_ENTROPY_BITS/8 + 1]; + char entropy[(PWQ_MAX_ENTROPY_BITS+PWQ_MAX_ENTROPY_BITS/9)/8 + 2]; char *tmp; int maxlen; int try = 0; -- cgit v1.2.1