From 47c3db97d1124cd5edc8500ef263138740b7e9ff Mon Sep 17 00:00:00 2001 From: Edward Thomson Date: Sun, 20 Jun 2021 11:02:59 -0500 Subject: remote: handle error case If `git_reference_resolve` fails with an actual error (not `GIT_ENOTFOUND`) it should not be ignored. --- src/remote.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/remote.c b/src/remote.c index 5f6ba5bf7..9e480db61 100644 --- a/src/remote.c +++ b/src/remote.c @@ -1137,8 +1137,10 @@ static int remote_head_for_ref(git_remote_head **out, git_remote *remote, git_re if (error == GIT_ENOTFOUND && git_reference_type(ref) == GIT_REFERENCE_SYMBOLIC) { ref_name = git_reference_symbolic_target(ref); error = 0; - } else { + } else if (!error) { ref_name = git_reference_name(resolved_ref); + } else { + goto cleanup; } /* -- cgit v1.2.1