From 909d5494368a00809bc42f4780e86f4dd66e4422 Mon Sep 17 00:00:00 2001 From: Edward Thomson Date: Thu, 29 Dec 2016 12:25:15 +0000 Subject: giterr_set: consistent error messages Error messages should be sentence fragments, and therefore: 1. Should not begin with a capital letter, 2. Should not conclude with punctuation, and 3. Should not end a sentence and begin a new one --- src/commit_list.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/commit_list.c') diff --git a/src/commit_list.c b/src/commit_list.c index a1681ffae..3bba58c27 100644 --- a/src/commit_list.c +++ b/src/commit_list.c @@ -61,7 +61,7 @@ static int commit_error(git_commit_list_node *commit, const char *msg) git_oid_fmt(commit_oid, &commit->oid); commit_oid[GIT_OID_HEXSZ] = '\0'; - giterr_set(GITERR_ODB, "Failed to parse commit %s - %s", commit_oid, msg); + giterr_set(GITERR_ODB, "failed to parse commit %s - %s", commit_oid, msg); return -1; } @@ -191,7 +191,7 @@ int git_commit_list_parse(git_revwalk *walk, git_commit_list_node *commit) return error; if (obj->cached.type != GIT_OBJ_COMMIT) { - giterr_set(GITERR_INVALID, "Object is no commit object"); + giterr_set(GITERR_INVALID, "object is no commit object"); error = -1; } else error = commit_quick_parse( -- cgit v1.2.1