From 9462c471435b4de74848408bebe41d770dc49a50 Mon Sep 17 00:00:00 2001 From: Vicent Marti Date: Fri, 25 Nov 2011 08:16:26 +0100 Subject: repository: Change ownership semantics The ownership semantics have been changed all over the library to be consistent. There are no more "borrowed" or duplicated references. Main changes: - `git_repository_open2` and `3` have been dropped. - Added setters and getters to hotswap all the repository owned objects: `git_repository_index` `git_repository_set_index` `git_repository_odb` `git_repository_set_odb` `git_repository_config` `git_repository_set_config` `git_repository_workdir` `git_repository_set_workdir` Now working directories/index files/ODBs and so on can be hot-swapped after creating a repository and between operations. - All these objects now have proper ownership semantics with refcounting: they all require freeing after they are no longer needed (the repository always keeps its internal reference). - Repository open and initialization has been updated to keep in mind the configuration files. Bare repositories are now always detected, and a default config file is created on init. - All the tests affected by these changes have been dropped from the old test suite and ported to the new one. --- src/commit.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'src/commit.c') diff --git a/src/commit.c b/src/commit.c index 83bc9fc4c..bf6ca7855 100644 --- a/src/commit.c +++ b/src/commit.c @@ -103,6 +103,7 @@ int git_commit_create( { git_buf commit = GIT_BUF_INIT; int error, i; + git_odb *odb; if (git_object_owner((const git_object *)tree) != repo) return git__throw(GIT_EINVALIDARGS, "The given tree does not belong to this repository"); @@ -132,7 +133,11 @@ int git_commit_create( goto cleanup; } - error = git_odb_write(oid, git_repository_database(repo), commit.ptr, commit.size, GIT_OBJ_COMMIT); + error = git_repository_odb__weakptr(&odb, repo); + if (error < GIT_SUCCESS) + goto cleanup; + + error = git_odb_write(oid, odb, commit.ptr, commit.size, GIT_OBJ_COMMIT); git_buf_free(&commit); if (error == GIT_SUCCESS && update_ref != NULL) { -- cgit v1.2.1