From 2b92a154b66f213b664e44544048a2df7708b9de Mon Sep 17 00:00:00 2001 From: nulltoken Date: Wed, 11 Jul 2012 11:20:20 +0200 Subject: commit: reduce code duplication --- src/commit.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) (limited to 'src/commit.c') diff --git a/src/commit.c b/src/commit.c index a3baf9d4e..5acbbc39b 100644 --- a/src/commit.c +++ b/src/commit.c @@ -229,19 +229,25 @@ GIT_COMMIT_GETTER(int, time_offset, commit->committer->when.offset) GIT_COMMIT_GETTER(unsigned int, parentcount, commit->parent_oids.length) GIT_COMMIT_GETTER(const git_oid *, tree_oid, &commit->tree_oid); - int git_commit_tree(git_tree **tree_out, git_commit *commit) { assert(commit); return git_tree_lookup(tree_out, commit->object.repo, &commit->tree_oid); } +const git_oid *git_commit_parent_oid(git_commit *commit, unsigned int n) +{ + assert(commit); + + return git_vector_get(&commit->parent_oids, n); +} + int git_commit_parent(git_commit **parent, git_commit *commit, unsigned int n) { - git_oid *parent_oid; + const git_oid *parent_oid; assert(commit); - parent_oid = git_vector_get(&commit->parent_oids, n); + parent_oid = git_commit_parent_oid(commit, n); if (parent_oid == NULL) { giterr_set(GITERR_INVALID, "Parent %u does not exist", n); return GIT_ENOTFOUND; @@ -249,10 +255,3 @@ int git_commit_parent(git_commit **parent, git_commit *commit, unsigned int n) return git_commit_lookup(parent, commit->object.repo, parent_oid); } - -const git_oid *git_commit_parent_oid(git_commit *commit, unsigned int n) -{ - assert(commit); - - return git_vector_get(&commit->parent_oids, n); -} -- cgit v1.2.1