From d10c846e4e91fc299de194b3d4dd76fc4451cf67 Mon Sep 17 00:00:00 2001 From: Christoph Thelen Date: Thu, 27 Aug 2020 21:47:48 +0200 Subject: Fix crash in git_describe_commit when opts are NULL. The argument "opts" can be NULL, which selects default options. Do not access "opts" directly but only the normalized copy. --- src/describe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/describe.c b/src/describe.c index c8a175214..8beffdeba 100644 --- a/src/describe.c +++ b/src/describe.c @@ -685,7 +685,7 @@ int git_describe_commit( get_name, &data)) < 0) goto cleanup; - if (git_oidmap_size(data.names) == 0 && !opts->show_commit_oid_as_fallback) { + if (git_oidmap_size(data.names) == 0 && !normalized.show_commit_oid_as_fallback) { git_error_set(GIT_ERROR_DESCRIBE, "cannot describe - " "no reference found, cannot describe anything."); error = -1; -- cgit v1.2.1