From 62eb2f8316902f81f5d55f684f3994672a1073bf Mon Sep 17 00:00:00 2001 From: Edward Thomson Date: Tue, 21 Sep 2021 10:59:49 -0400 Subject: email: don't clear buffer in append function `git_email__append_from_diff` is meant to - well, append from a diff. Clearing the buffer, by definition, is not appending. Stop doing that. --- src/email.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/email.c b/src/email.c index 8957d9a38..df63b6ec3 100644 --- a/src/email.c +++ b/src/email.c @@ -217,7 +217,6 @@ int git_email__append_from_diff( memcpy(&opts, given_opts, sizeof(git_email_create_options)); git_buf_sanitize(out); - git_buf_clear(out); if ((error = append_header(out, patch_idx, patch_count, commit_id, summary, author, &opts)) == 0 && (error = append_body(out, body)) == 0 && -- cgit v1.2.1 From 470acc718888782646347ae6e450bc167144acfd Mon Sep 17 00:00:00 2001 From: Edward Thomson Date: Tue, 21 Sep 2021 11:01:27 -0400 Subject: rebase: fix (deprecated) signing test --- tests/rebase/sign.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/rebase/sign.c b/tests/rebase/sign.c index 8b0473c3c..06c18937a 100644 --- a/tests/rebase/sign.c +++ b/tests/rebase/sign.c @@ -249,13 +249,7 @@ void test_rebase_sign__create_propagates_error(void) } #ifndef GIT_DEPRECATE_HARD -int signing_cb_passthrough( - git_buf *signature, - git_buf *signature_field, - const char *commit_content, - void *payload) -{ - static const char *expected_commit_content = "\ +static const char *expected_commit_content = "\ tree cd99b26250099fc38d30bfaed7797a7275ed3366\n\ parent f87d14a4a236582a0278a916340a793714256864\n\ author Edward Thomson 1405625055 -0400\n\ @@ -263,6 +257,12 @@ committer Rebaser 1405694510 +0000\n\ \n\ Modification 3 to gravy\n"; +int signing_cb_passthrough( + git_buf *signature, + git_buf *signature_field, + const char *commit_content, + void *payload) +{ cl_assert_equal_b(false, git_buf_is_allocated(signature)); cl_assert_equal_b(false, git_buf_is_allocated(signature_field)); cl_assert_equal_s(expected_commit_content, commit_content); -- cgit v1.2.1