From 21981f28627b65d43590166b6a1782bb101dcddd Mon Sep 17 00:00:00 2001 From: panda Date: Tue, 16 Feb 2021 13:43:09 -0800 Subject: index: Check git_vector_dup error in write_entries If allocating case_sorted.contents fails, git_vector_sort will segfault. --- src/index.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/index.c b/src/index.c index 7ebe07582..263f8e586 100644 --- a/src/index.c +++ b/src/index.c @@ -2868,7 +2868,9 @@ static int write_entries(git_index *index, git_filebuf *file) /* If index->entries is sorted case-insensitively, then we need * to re-sort it case-sensitively before writing */ if (index->ignore_case) { - git_vector_dup(&case_sorted, &index->entries, git_index_entry_cmp); + if ((error = git_vector_dup(&case_sorted, &index->entries, git_index_entry_cmp)) < 0) + return error; + git_vector_sort(&case_sorted); entries = &case_sorted; } else { -- cgit v1.2.1