<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/libgit2.git/tests, branch peff/binary-search-do-while</title>
<subtitle>github.com: libgit2/libgit2.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/'/>
<entry>
<title>Merge branch '4233'</title>
<updated>2017-07-30T23:59:27+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2017-07-30T23:58:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=fb585d01205e1a0b580a39f9cbdc829ff63e02c9'/>
<id>fb585d01205e1a0b580a39f9cbdc829ff63e02c9</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>tests: rebase::submodule: verify initialization method calls</title>
<updated>2017-07-28T07:01:41+00:00</updated>
<author>
<name>Patrick Steinhardt</name>
<email>ps@pks.im</email>
</author>
<published>2017-07-28T07:01:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=c0558c62989215d724ebc3b267ae1022618c49e8'/>
<id>c0558c62989215d724ebc3b267ae1022618c49e8</id>
<content type='text'>
Some return codes for functions which may fail are not being checked in
`test_rebase_submodule__initialize`. This may lead us to not notice
errors when initializing the environment and would possibly result in
either memory corruption or segfaults as soon as any of the
initialization steps fails. Fix this by wrapping these function calls
into `cl_git_pass`.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Some return codes for functions which may fail are not being checked in
`test_rebase_submodule__initialize`. This may lead us to not notice
errors when initializing the environment and would possibly result in
either memory corruption or segfaults as soon as any of the
initialization steps fails. Fix this by wrapping these function calls
into `cl_git_pass`.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #4275 from tiennou/fix-rebase-submodule-test</title>
<updated>2017-07-27T22:05:53+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2017-07-27T22:05:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=4f4bc5732baf4545ab42bbd80d2a971e2f1e316c'/>
<id>4f4bc5732baf4545ab42bbd80d2a971e2f1e316c</id>
<content type='text'>
tests: rewrite rebase-submodule .gitmodule file</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
tests: rewrite rebase-submodule .gitmodule file</pre>
</div>
</content>
</entry>
<entry>
<title>tests: fix the rebase-submodule test</title>
<updated>2017-07-25T18:38:44+00:00</updated>
<author>
<name>Etienne Samson</name>
<email>samson.etienne@gmail.com</email>
</author>
<published>2017-07-20T21:00:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=35cb7b840d54030efdb22a0a908dd6acfd247aa7'/>
<id>35cb7b840d54030efdb22a0a908dd6acfd247aa7</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove invalid submodule</title>
<updated>2017-07-20T21:00:15+00:00</updated>
<author>
<name>Etienne Samson</name>
<email>samson.etienne@gmail.com</email>
</author>
<published>2017-06-21T12:57:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=45994fdcb0fab813b4bc8a9af3edc312f8727794'/>
<id>45994fdcb0fab813b4bc8a9af3edc312f8727794</id>
<content type='text'>
Fixes #4274</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes #4274</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #4250 from pks-t/pks/config-file-iteration</title>
<updated>2017-07-19T20:55:55+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2017-07-19T20:55:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=e0568621535869451c91e915d28a69ac7c84b8b7'/>
<id>e0568621535869451c91e915d28a69ac7c84b8b7</id>
<content type='text'>
Configuration file fixes with includes</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Configuration file fixes with includes</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #4272 from pks-t/pks/patch-id</title>
<updated>2017-07-19T20:28:32+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2017-07-19T20:28:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=a94a54021c118df5d0cf526c0ace4bd96a442f39'/>
<id>a94a54021c118df5d0cf526c0ace4bd96a442f39</id>
<content type='text'>
Patch ID calculation</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Patch ID calculation</pre>
</div>
</content>
</entry>
<entry>
<title>config_file: refuse modifying included variables</title>
<updated>2017-07-15T12:14:50+00:00</updated>
<author>
<name>Patrick Steinhardt</name>
<email>ps@pks.im</email>
</author>
<published>2017-05-31T20:27:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=1b32908973d687e4526079eeecdb82d9cb13c6e6'/>
<id>1b32908973d687e4526079eeecdb82d9cb13c6e6</id>
<content type='text'>
Modifying variables pulled in by an included file currently succeeds,
but it doesn't actually do what one would expect, as refreshing the
configuration will cause the values to reappear. As we are currently not
really able to support this use case, we will instead just return an
error for deleting and setting variables which were included via an
include.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Modifying variables pulled in by an included file currently succeeds,
but it doesn't actually do what one would expect, as refreshing the
configuration will cause the values to reappear. As we are currently not
really able to support this use case, we will instead just return an
error for deleting and setting variables which were included via an
include.
</pre>
</div>
</content>
</entry>
<entry>
<title>config_file: move reader into `config_read` only</title>
<updated>2017-07-15T12:14:50+00:00</updated>
<author>
<name>Patrick Steinhardt</name>
<email>ps@pks.im</email>
</author>
<published>2017-05-31T14:41:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=28c2cc3de33a382a5ca6858c418ecd541ab57aeb'/>
<id>28c2cc3de33a382a5ca6858c418ecd541ab57aeb</id>
<content type='text'>
Right now, we have multiple call sites which initialize a `reader`
structure. As the structure is only actually used inside of
`config_read`, we can instead just move the reader inside of the
`config_read` function. Instead, we can just pass in the configuration
file into `config_read`, which eases code readability.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Right now, we have multiple call sites which initialize a `reader`
structure. As the structure is only actually used inside of
`config_read`, we can instead just move the reader inside of the
`config_read` function. Instead, we can just pass in the configuration
file into `config_read`, which eases code readability.
</pre>
</div>
</content>
</entry>
<entry>
<title>config_file: refresh all files if includes were modified</title>
<updated>2017-07-15T12:14:50+00:00</updated>
<author>
<name>Patrick Steinhardt</name>
<email>ps@pks.im</email>
</author>
<published>2017-05-31T20:45:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=83bcd3a1911c136b4ace33fecde889c347452718'/>
<id>83bcd3a1911c136b4ace33fecde889c347452718</id>
<content type='text'>
Currently, we only re-parse the top-level configuration file when it has
changed itself. This can cause problems when an include is changed, as
we were not updating all values correctly.

Instead of conditionally reparsing only refreshed files, the logic
becomes much clearer and easier to follow if we always re-parse the
top-level configuration file when either the file itself or one of its
included configuration files has changed on disk. This commit implements
this logic.

Note that this might impact performance in some cases, as we need to
re-read all configuration files whenever any of the included files
changed. It could increase performance to just re-parse include files
which have actually changed, but this would compromise maintainability
of the code without much gain. The only case where we will gain anything
is when we actually use includes and when only these includes are
updated, which will probably be quite an unusual scenario to actually be
worthwhile to optimize.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Currently, we only re-parse the top-level configuration file when it has
changed itself. This can cause problems when an include is changed, as
we were not updating all values correctly.

Instead of conditionally reparsing only refreshed files, the logic
becomes much clearer and easier to follow if we always re-parse the
top-level configuration file when either the file itself or one of its
included configuration files has changed on disk. This commit implements
this logic.

Note that this might impact performance in some cases, as we need to
re-read all configuration files whenever any of the included files
changed. It could increase performance to just re-parse include files
which have actually changed, but this would compromise maintainability
of the code without much gain. The only case where we will gain anything
is when we actually use includes and when only these includes are
updated, which will probably be quite an unusual scenario to actually be
worthwhile to optimize.
</pre>
</div>
</content>
</entry>
</feed>
