<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/libgit2.git/tests, branch cmn/commit-create-safe</title>
<subtitle>github.com: libgit2/libgit2.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/'/>
<entry>
<title>commit: safer commit creation with reference update</title>
<updated>2014-04-29T22:41:37+00:00</updated>
<author>
<name>Carlos Martín Nieto</name>
<email>cmn@dwim.me</email>
</author>
<published>2014-04-09T12:08:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=217c029b54e8f1574ae6bc71c4b25533ecff3b6a'/>
<id>217c029b54e8f1574ae6bc71c4b25533ecff3b6a</id>
<content type='text'>
The current version of the commit creation and amend function are unsafe
to use when passing the update_ref parameter, as they do not check that
the reference at the moment of update points to what the user expects.

Make sure that we're moving history forward when we ask the library to
update the reference for us by checking that the first parent of the new
commit is the current value of the reference. We also make sure that the
ref we're updating hasn't moved between the read and the write.

Similarly, when amending a commit, make sure that the current tip of the
branch is the commit we're amending.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The current version of the commit creation and amend function are unsafe
to use when passing the update_ref parameter, as they do not check that
the reference at the moment of update points to what the user expects.

Make sure that we're moving history forward when we ask the library to
update the reference for us by checking that the first parent of the new
commit is the current value of the reference. We also make sure that the
ref we're updating hasn't moved between the read and the write.

Similarly, when amending a commit, make sure that the current tip of the
branch is the commit we're amending.
</pre>
</div>
</content>
</entry>
<entry>
<title>Reset tests: Use sandboxed index</title>
<updated>2014-04-25T13:49:58+00:00</updated>
<author>
<name>Jiri Pospisil</name>
<email>mekishizufu@gmail.com</email>
</author>
<published>2014-04-25T13:49:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=7b8d564d5da4745e9227676a8768b3b48ca3dff8'/>
<id>7b8d564d5da4745e9227676a8768b3b48ca3dff8</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #2284 from jacquesg/push-progress-callback</title>
<updated>2014-04-25T09:10:19+00:00</updated>
<author>
<name>Vicent Marti</name>
<email>vicent@github.com</email>
</author>
<published>2014-04-25T09:10:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=8443ed6c1d1237e203474a772fb4281c382df6ac'/>
<id>8443ed6c1d1237e203474a772fb4281c382df6ac</id>
<content type='text'>
Fire progress and update tips callbacks also for pushes.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fire progress and update tips callbacks also for pushes.</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #2297 from libgit2/rb/status-with-precomposed-changes</title>
<updated>2014-04-25T09:07:42+00:00</updated>
<author>
<name>Vicent Marti</name>
<email>vicent@github.com</email>
</author>
<published>2014-04-25T09:07:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=332e4f20273a424efcea06ca1550146c816f4404'/>
<id>332e4f20273a424efcea06ca1550146c816f4404</id>
<content type='text'>
Improve test coverage of status with different core.precomposeunicode settings</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Improve test coverage of status with different core.precomposeunicode settings</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #2241 from libgit2/rb/stash-skip-submodules</title>
<updated>2014-04-25T09:04:12+00:00</updated>
<author>
<name>Vicent Marti</name>
<email>vicent@github.com</email>
</author>
<published>2014-04-25T09:04:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=2ad51b81d2d735c50549f16c308d61c0a5ed990c'/>
<id>2ad51b81d2d735c50549f16c308d61c0a5ed990c</id>
<content type='text'>
Improve stash and checkout for ignored + untracked items</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Improve stash and checkout for ignored + untracked items</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #2294 from ethomson/merge_checkout_strategy</title>
<updated>2014-04-24T23:20:08+00:00</updated>
<author>
<name>Russell Belfer</name>
<email>rb@github.com</email>
</author>
<published>2014-04-24T23:20:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=af9eeac93929bdf10c30e60f34717959d83b6bd3'/>
<id>af9eeac93929bdf10c30e60f34717959d83b6bd3</id>
<content type='text'>
Merge checkout strategy</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Merge checkout strategy</pre>
</div>
</content>
</entry>
<entry>
<title>Improve docs for status rename detection limits</title>
<updated>2014-04-24T22:40:50+00:00</updated>
<author>
<name>Russell Belfer</name>
<email>rb@github.com</email>
</author>
<published>2014-04-24T22:40:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=6b833e3a4a29d76e25120cf374838404a6b68825'/>
<id>6b833e3a4a29d76e25120cf374838404a6b68825</id>
<content type='text'>
and make tests empty on platforms without iconv support.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
and make tests empty on platforms without iconv support.
</pre>
</div>
</content>
</entry>
<entry>
<title>Test toggling core.precomposeunicode yields rename</title>
<updated>2014-04-24T22:25:01+00:00</updated>
<author>
<name>Russell Belfer</name>
<email>rb@github.com</email>
</author>
<published>2014-04-24T22:25:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=f608f3bb274dbf413127ba352f48021ed538139e'/>
<id>f608f3bb274dbf413127ba352f48021ed538139e</id>
<content type='text'>
There is an interesting difference with core Git here, though.
Because libgit2 will do rename detection with the working directory,
in the last case where the HEAD and the working directory both
have the decomposed data and the index has the composed data, we
generate a single status record with two renames whereas Git will
generate one rename (head to index) and one untracked file.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
There is an interesting difference with core Git here, though.
Because libgit2 will do rename detection with the working directory,
in the last case where the HEAD and the working directory both
have the decomposed data and the index has the composed data, we
generate a single status record with two renames whereas Git will
generate one rename (head to index) and one untracked file.
</pre>
</div>
</content>
</entry>
<entry>
<title>Test decomposed unicode renames work as expected</title>
<updated>2014-04-24T21:46:59+00:00</updated>
<author>
<name>Russell Belfer</name>
<email>rb@github.com</email>
</author>
<published>2014-04-24T21:46:59+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=2334e3d8c33c639732e586ae8adfb65370523ab2'/>
<id>2334e3d8c33c639732e586ae8adfb65370523ab2</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>fetchhead: deal with quotes in branch names</title>
<updated>2014-04-24T12:08:29+00:00</updated>
<author>
<name>Carlos Martín Nieto</name>
<email>cmn@dwim.me</email>
</author>
<published>2014-04-24T12:08:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=bdc82e1c00776229b19688abaf08d6701f2dc41f'/>
<id>bdc82e1c00776229b19688abaf08d6701f2dc41f</id>
<content type='text'>
The current FETCH_HEAD parsing code assumes that a quote must end the
branch name. Git however allows for quotes as part of a branch name,
which causes us to consider the FETCH_HEAD file as invalid.

Instead of searching for a single quote char, search for a quote char
followed by SP, which is not a valid part of a ref name.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The current FETCH_HEAD parsing code assumes that a quote must end the
branch name. Git however allows for quotes as part of a branch name,
which causes us to consider the FETCH_HEAD file as invalid.

Instead of searching for a single quote char, search for a quote char
followed by SP, which is not a valid part of a ref name.
</pre>
</div>
</content>
</entry>
</feed>
