<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/libgit2.git/tests/notes, branch ethomson/test_https</title>
<subtitle>github.com: libgit2/libgit2.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/'/>
<entry>
<title>tests: declare functions statically where appropriate</title>
<updated>2021-11-11T22:31:43+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-11-11T18:28:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=ca14942e19788bd01334af64554c3095f3ff0d4a'/>
<id>ca14942e19788bd01334af64554c3095f3ff0d4a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>str: introduce `git_str` for internal, `git_buf` is external</title>
<updated>2021-10-17T13:49:01+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-09-07T21:53:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=f0e693b18afbe1de37d7da5b5a8967b6c87d8e53'/>
<id>f0e693b18afbe1de37d7da5b5a8967b6c87d8e53</id>
<content type='text'>
libgit2 has two distinct requirements that were previously solved by
`git_buf`.  We require:

1. A general purpose string class that provides a number of utility APIs
   for manipulating data (eg, concatenating, truncating, etc).
2. A structure that we can use to return strings to callers that they
   can take ownership of.

By using a single class (`git_buf`) for both of these purposes, we have
confused the API to the point that refactorings are difficult and
reasoning about correctness is also difficult.

Move the utility class `git_buf` to be called `git_str`: this represents
its general purpose, as an internal string buffer class.  The name also
is an homage to Junio Hamano ("gitstr").

The public API remains `git_buf`, and has a much smaller footprint.  It
is generally only used as an "out" param with strict requirements that
follow the documentation.  (Exceptions exist for some legacy APIs to
avoid breaking callers unnecessarily.)

Utility functions exist to convert a user-specified `git_buf` to a
`git_str` so that we can call internal functions, then converting it
back again.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
libgit2 has two distinct requirements that were previously solved by
`git_buf`.  We require:

1. A general purpose string class that provides a number of utility APIs
   for manipulating data (eg, concatenating, truncating, etc).
2. A structure that we can use to return strings to callers that they
   can take ownership of.

By using a single class (`git_buf`) for both of these purposes, we have
confused the API to the point that refactorings are difficult and
reasoning about correctness is also difficult.

Move the utility class `git_buf` to be called `git_str`: this represents
its general purpose, as an internal string buffer class.  The name also
is an homage to Junio Hamano ("gitstr").

The public API remains `git_buf`, and has a much smaller footprint.  It
is generally only used as an "out" param with strict requirements that
follow the documentation.  (Exceptions exist for some legacy APIs to
avoid breaking callers unnecessarily.)

Utility functions exist to convert a user-specified `git_buf` to a
`git_str` so that we can call internal functions, then converting it
back again.
</pre>
</div>
</content>
</entry>
<entry>
<title>tests: add missing error checks</title>
<updated>2020-02-07T10:53:51+00:00</updated>
<author>
<name>Patrick Steinhardt</name>
<email>ps@pks.im</email>
</author>
<published>2020-02-07T10:53:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=2e6cbff86e74b6eaa9b90dc8adc205b9d940a481'/>
<id>2e6cbff86e74b6eaa9b90dc8adc205b9d940a481</id>
<content type='text'>
We should always verify error codes returned by function calls in our
test suite to not accidentally miss any weird results. Coverity reported
missing checks in several locations, which this commit fixes.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We should always verify error codes returned by function calls in our
test suite to not accidentally miss any weird results. Coverity reported
missing checks in several locations, which this commit fixes.
</pre>
</div>
</content>
</entry>
<entry>
<title>Convert usage of `git_buf_free` to new `git_buf_dispose`</title>
<updated>2018-06-10T17:34:37+00:00</updated>
<author>
<name>Patrick Steinhardt</name>
<email>ps@pks.im</email>
</author>
<published>2018-02-08T11:14:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=ecf4f33a4e327a91496f72816f9f02d923e5af05'/>
<id>ecf4f33a4e327a91496f72816f9f02d923e5af05</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>notes: Add test that read of noteless commit fails</title>
<updated>2017-12-02T18:19:29+00:00</updated>
<author>
<name>Richard Ipsum</name>
<email>richardipsum@fastmail.co.uk</email>
</author>
<published>2017-09-23T16:19:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=4623c25f700be43efc5138e39d52ecff4c240b02'/>
<id>4623c25f700be43efc5138e39d52ecff4c240b02</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>notes: Add git_note_commit_iterator_new</title>
<updated>2017-10-06T23:43:40+00:00</updated>
<author>
<name>Richard Ipsum</name>
<email>richardipsum@fastmail.co.uk</email>
</author>
<published>2017-03-19T18:34:07+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=60bee89d4697832f88c484f0c236e7f25c3d62fe'/>
<id>60bee89d4697832f88c484f0c236e7f25c3d62fe</id>
<content type='text'>
This also adds tests for this function.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This also adds tests for this function.
</pre>
</div>
</content>
</entry>
<entry>
<title>notes: Add git_note_commit_remove</title>
<updated>2017-10-06T23:43:29+00:00</updated>
<author>
<name>Richard Ipsum</name>
<email>richardipsum@fastmail.co.uk</email>
</author>
<published>2017-03-15T18:17:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=9a02725d11acb302b0d9ef7013ae81ffd59525c7'/>
<id>9a02725d11acb302b0d9ef7013ae81ffd59525c7</id>
<content type='text'>
This also adds tests for this function.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This also adds tests for this function.
</pre>
</div>
</content>
</entry>
<entry>
<title>notes: Add git_note_commit_read</title>
<updated>2017-10-06T23:33:23+00:00</updated>
<author>
<name>Richard Ipsum</name>
<email>richardipsum@fastmail.co.uk</email>
</author>
<published>2017-03-15T11:54:45+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=7096bf1ef6b5c7c5659ea9d8c66c85bda8ef20db'/>
<id>7096bf1ef6b5c7c5659ea9d8c66c85bda8ef20db</id>
<content type='text'>
This also adds tests for this function.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This also adds tests for this function.
</pre>
</div>
</content>
</entry>
<entry>
<title>notes: Add git_note_commit_create</title>
<updated>2017-10-06T23:31:54+00:00</updated>
<author>
<name>Richard Ipsum</name>
<email>richardipsum@fastmail.co.uk</email>
</author>
<published>2017-09-23T16:46:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=a46e743d0153b9a565614776b9f3a71e0aebff25'/>
<id>a46e743d0153b9a565614776b9f3a71e0aebff25</id>
<content type='text'>
This adds a new function that will allow creation of notes without
necessarily updating a particular ref, the notes tree is obtained
from the git_commit object parameter, a new commit object pointing
to the current tip of the notes tree is optionally returned
via the 'note_commit_out' parameter,
optionally the blob id for the note is returned through
the 'note_blob_out' object.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This adds a new function that will allow creation of notes without
necessarily updating a particular ref, the notes tree is obtained
from the git_commit object parameter, a new commit object pointing
to the current tip of the notes tree is optionally returned
via the 'note_commit_out' parameter,
optionally the blob id for the note is returned through
the 'note_blob_out' object.
</pre>
</div>
</content>
</entry>
<entry>
<title>note: use a git_buf to return the default namespace</title>
<updated>2015-03-17T19:50:02+00:00</updated>
<author>
<name>Carlos Martín Nieto</name>
<email>cmn@dwim.me</email>
</author>
<published>2015-03-04T00:23:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=385449b1df593440abcf6636c81eb5ea19b1d1a1'/>
<id>385449b1df593440abcf6636c81eb5ea19b1d1a1</id>
<content type='text'>
The caller has otherwise no way to know how long the string will be
allocated or ability to free it.

This fixes #2944.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The caller has otherwise no way to know how long the string will be
allocated or ability to free it.

This fixes #2944.
</pre>
</div>
</content>
</entry>
</feed>
