<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/libgit2.git/src, branch ethomson/tag_valid</title>
<subtitle>github.com: libgit2/libgit2.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/'/>
<entry>
<title>tag: set validity to 0 by default</title>
<updated>2021-11-17T04:21:53+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-11-17T04:21:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=6b2ea90966fd090e3b134ec57b85a8adfe4b89be'/>
<id>6b2ea90966fd090e3b134ec57b85a8adfe4b89be</id>
<content type='text'>
`git_tag_name_is_valid` needs to set validity to 0 when it
short-circuits.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
`git_tag_name_is_valid` needs to set validity to 0 when it
short-circuits.
</pre>
</div>
</content>
</entry>
<entry>
<title>Make enum in src,tests and examples C90 compliant by removing trailing comma.</title>
<updated>2021-11-15T15:45:40+00:00</updated>
<author>
<name>Peter Pettersson</name>
<email>boretrk@hotmail.com</email>
</author>
<published>2021-10-22T20:51:59+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=7dcc29fc4652caeb09de39827cfd1a80726b5995'/>
<id>7dcc29fc4652caeb09de39827cfd1a80726b5995</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>cmake: move sha1 source selection into CMakeLists.txt</title>
<updated>2021-11-14T12:25:41+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-11-12T04:09:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=2c154145a8f7ce3c01f1afc40e3934c1e43c377e'/>
<id>2c154145a8f7ce3c01f1afc40e3934c1e43c377e</id>
<content type='text'>
The select hashes module selects the hash; the CMakeLists.txt selects
the files to implement it.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The select hashes module selects the hash; the CMakeLists.txt selects
the files to implement it.
</pre>
</div>
</content>
</entry>
<entry>
<title>cmake: refactor global variables</title>
<updated>2021-11-14T12:25:41+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-11-12T03:10:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=395b3dc403621f1ab3c400780b057cae91c6f6c1'/>
<id>395b3dc403621f1ab3c400780b057cae91c6f6c1</id>
<content type='text'>
Update the global variables `LIBGIT2_OBJECTS` to
`LIBGIT2_DEPENDENCY_OBJECTS` for clarity and consistency.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Update the global variables `LIBGIT2_OBJECTS` to
`LIBGIT2_DEPENDENCY_OBJECTS` for clarity and consistency.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #6116 from lhchavez/drop-volatile-qualifier-in-atomic-exchange</title>
<updated>2021-11-14T12:23:01+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@github.com</email>
</author>
<published>2021-11-14T12:23:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=b608af6c3a2502ae61b94416a482c2e0672286a4'/>
<id>b608af6c3a2502ae61b94416a482c2e0672286a4</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix a gcc 11 warning in src/thread.h</title>
<updated>2021-11-14T10:31:48+00:00</updated>
<author>
<name>lhchavez</name>
<email>lhchavez@lhchavez.com</email>
</author>
<published>2021-11-14T10:27:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=5675312e5aeb0c8b438df3ba9da7542673b2e0e7'/>
<id>5675312e5aeb0c8b438df3ba9da7542673b2e0e7</id>
<content type='text'>
When building under gcc 11, there is a warning about an incompatible pointer
type, since
[`__atomic_exchange`](https://gcc.gnu.org/onlinedocs/gcc/_005f_005fatomic-Builtins.html)
does not take `volatile` pointers:

```
In file included from ../src/common.h:81,
                 from ../src/transports/winhttp.c:8:
../src/thread-utils.h: In function ‘git___swap’:
../src/thread-utils.h:168:9: warning: argument 3 of ‘__atomic_exchange’ discards ‘volatile’ qualifier [-Wincompatible-pointer-types]
  168 |         __atomic_exchange(ptr, &amp;newval, &amp;foundval, __ATOMIC_SEQ_CST);
      |         ^~~~~~~~~~~~~~~~~
```

This change drops the `volatile` qualifier so that the pointer type matches
what `__atomic_exchange` expects.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When building under gcc 11, there is a warning about an incompatible pointer
type, since
[`__atomic_exchange`](https://gcc.gnu.org/onlinedocs/gcc/_005f_005fatomic-Builtins.html)
does not take `volatile` pointers:

```
In file included from ../src/common.h:81,
                 from ../src/transports/winhttp.c:8:
../src/thread-utils.h: In function ‘git___swap’:
../src/thread-utils.h:168:9: warning: argument 3 of ‘__atomic_exchange’ discards ‘volatile’ qualifier [-Wincompatible-pointer-types]
  168 |         __atomic_exchange(ptr, &amp;newval, &amp;foundval, __ATOMIC_SEQ_CST);
      |         ^~~~~~~~~~~~~~~~~
```

This change drops the `volatile` qualifier so that the pointer type matches
what `__atomic_exchange` expects.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix a gcc 11 warning in src/threadstate.c</title>
<updated>2021-11-14T10:24:39+00:00</updated>
<author>
<name>lhchavez</name>
<email>lhchavez@lhchavez.com</email>
</author>
<published>2021-11-14T10:24:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=0c4d24dad2db95132568043bb086dff2af400eda'/>
<id>0c4d24dad2db95132568043bb086dff2af400eda</id>
<content type='text'>
When building under gcc 11, there is a warning about a misaligned guard clause
because there were mixed spaces and tabs:

```
[128/634] Building C object src/CMakeFiles/git2internal.dir/threadstate.c.o
../src/threadstate.c: In function ‘threadstate_dispose’:
../src/threadstate.c:39:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
   39 |     if (threadstate-&gt;error_t.message != git_str__initstr)
      |     ^~
../src/threadstate.c:41:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
   41 |         threadstate-&gt;error_t.message = NULL;
      |         ^~~~~~~~~~~
../src/threadstate.c: At top level:
```

This change indents the code with tabs for consistency with the rest of the
code, which makes the warning go away.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When building under gcc 11, there is a warning about a misaligned guard clause
because there were mixed spaces and tabs:

```
[128/634] Building C object src/CMakeFiles/git2internal.dir/threadstate.c.o
../src/threadstate.c: In function ‘threadstate_dispose’:
../src/threadstate.c:39:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
   39 |     if (threadstate-&gt;error_t.message != git_str__initstr)
      |     ^~
../src/threadstate.c:41:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
   41 |         threadstate-&gt;error_t.message = NULL;
      |         ^~~~~~~~~~~
../src/threadstate.c: At top level:
```

This change indents the code with tabs for consistency with the rest of the
code, which makes the warning go away.
</pre>
</div>
</content>
</entry>
<entry>
<title>cmake: move missing-declarations warning to top-level</title>
<updated>2021-11-11T22:31:43+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-11-11T22:04:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=4a6ef5a4a6cabfaa7147aab28130da49e5b177ea'/>
<id>4a6ef5a4a6cabfaa7147aab28130da49e5b177ea</id>
<content type='text'>
We should enforce declarations throughout the code-base, including
examples, fuzzers and tests, not just in the `src` tree.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We should enforce declarations throughout the code-base, including
examples, fuzzers and tests, not just in the `src` tree.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #6112 from libgit2/ethomson/cmake3</title>
<updated>2021-11-11T21:13:38+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-11-11T21:13:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=7687948ac129fb097d822a3b6a8787fa037cb240'/>
<id>7687948ac129fb097d822a3b6a8787fa037cb240</id>
<content type='text'>
cmake refactorings</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
cmake refactorings</pre>
</div>
</content>
</entry>
<entry>
<title>cmake: refactor zlib selection</title>
<updated>2021-11-11T20:56:11+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-11-11T02:59:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=4e84ddd5b091b6e6e85ff6484e72d9f90da1c4b0'/>
<id>4e84ddd5b091b6e6e85ff6484e72d9f90da1c4b0</id>
<content type='text'>
Move zlib selection into its own cmake module.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Move zlib selection into its own cmake module.
</pre>
</div>
</content>
</entry>
</feed>
