<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/libgit2.git/src, branch ethomson/callback_names</title>
<subtitle>github.com: libgit2/libgit2.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/'/>
<entry>
<title>trace: suffix the callbacks with `_cb`</title>
<updated>2019-06-10T10:37:00+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2019-06-08T22:16:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=178df697e3650972a70c8b812c7a1222eecaffb7'/>
<id>178df697e3650972a70c8b812c7a1222eecaffb7</id>
<content type='text'>
The trace logging callbacks should match the other callback naming
conventions, using the `_cb` suffix instead of a `_callback` suffix.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The trace logging callbacks should match the other callback naming
conventions, using the `_cb` suffix instead of a `_callback` suffix.
</pre>
</div>
</content>
</entry>
<entry>
<title>credentials: suffix the callbacks with `_cb`</title>
<updated>2019-06-10T10:37:00+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2019-06-08T22:14:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=810cefd93fce0eaca7d1dc09d366145be5214e76'/>
<id>810cefd93fce0eaca7d1dc09d366145be5214e76</id>
<content type='text'>
The credential callbacks should match the other callback naming
conventions, using the `_cb` suffix instead of a `_callback` suffix.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The credential callbacks should match the other callback naming
conventions, using the `_cb` suffix instead of a `_callback` suffix.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #5095 from pks-t/pks/ignore-escaped-trailing-space</title>
<updated>2019-06-06T13:48:30+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2019-06-06T13:48:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=e50d138e898dd034161663873f75716086266f86'/>
<id>e50d138e898dd034161663873f75716086266f86</id>
<content type='text'>
ignore: handle escaped trailing whitespace</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
ignore: handle escaped trailing whitespace</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #5074 from libgit2/ethomson/ignore_leading_slash</title>
<updated>2019-06-06T13:47:43+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2019-06-06T13:47:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=4de6eb5b8ba559c1f18a6e7631d7800e294849c8'/>
<id>4de6eb5b8ba559c1f18a6e7631d7800e294849c8</id>
<content type='text'>
Ignore: only treat one leading slash as a root identifier</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Ignore: only treat one leading slash as a root identifier</pre>
</div>
</content>
</entry>
<entry>
<title>ignore: handle escaped trailing whitespace</title>
<updated>2019-06-06T12:44:43+00:00</updated>
<author>
<name>Patrick Steinhardt</name>
<email>ps@pks.im</email>
</author>
<published>2019-06-06T12:11:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=d81e7866aba52625aa3100764d77c73adba58c8e'/>
<id>d81e7866aba52625aa3100764d77c73adba58c8e</id>
<content type='text'>
The gitignore's pattern format specifies that "Trailing spaces
are ignored unless they are quoted with backslash ("\")". We do
not honor this currently and will treat a pattern "foo\ " as if
it was "foo\" only and a pattern "foo\ \ " as "foo\ \".

Fix our code to handle those special cases and add tests to avoid
regressions.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The gitignore's pattern format specifies that "Trailing spaces
are ignored unless they are quoted with backslash ("\")". We do
not honor this currently and will treat a pattern "foo\ " as if
it was "foo\" only and a pattern "foo\ \ " as "foo\ \".

Fix our code to handle those special cases and add tests to avoid
regressions.
</pre>
</div>
</content>
</entry>
<entry>
<title>attr_file: refactor stripping of trailing spaces</title>
<updated>2019-06-06T12:15:36+00:00</updated>
<author>
<name>Patrick Steinhardt</name>
<email>ps@pks.im</email>
</author>
<published>2019-06-06T12:02:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=b6967c393aaa9bc8fcb1f248f94a4deb897248cb'/>
<id>b6967c393aaa9bc8fcb1f248f94a4deb897248cb</id>
<content type='text'>
The stripping of trailing spaces currently happens as part of
`git_attr_fnmatch__parse`. As we aren't currently parsing
trailing whitespaces correct in case they're escaped, we'll have
to change that code, though. To make actual behavioural change
easier to review, refactor the code up-front by pulling it out
into its own function that is expected to retain the exact same
functionality as before. Like this, the fix will be trivial to
apply.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The stripping of trailing spaces currently happens as part of
`git_attr_fnmatch__parse`. As we aren't currently parsing
trailing whitespaces correct in case they're escaped, we'll have
to change that code, though. To make actual behavioural change
easier to review, refactor the code up-front by pulling it out
into its own function that is expected to retain the exact same
functionality as before. Like this, the fix will be trivial to
apply.
</pre>
</div>
</content>
</entry>
<entry>
<title>attr: optionally treat leading whitespace as significant</title>
<updated>2019-05-24T14:16:43+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2019-05-19T14:27:59+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=63adcc4e3436abb163426ee431a6f77c29415b10'/>
<id>63adcc4e3436abb163426ee431a6f77c29415b10</id>
<content type='text'>
When `allow_space` is unset, ensure that leading whitespace is not
skipped.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When `allow_space` is unset, ensure that leading whitespace is not
skipped.
</pre>
</div>
</content>
</entry>
<entry>
<title>cache: fix cache eviction using deallocated key</title>
<updated>2019-05-24T13:28:33+00:00</updated>
<author>
<name>Patrick Steinhardt</name>
<email>ps@pks.im</email>
</author>
<published>2019-05-24T13:24:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=add1743580149c3d1e570aafff3180cee216162e'/>
<id>add1743580149c3d1e570aafff3180cee216162e</id>
<content type='text'>
When evicting cache entries, we first retrieve the object that is
to be evicted, delete the object and then finally delete the key
from the cache. In case where the cache eviction caused us to
free the cached object, though, its key will point to invalid
memory now when trying to remove it from the cache map. On my
system, this causes us to not properly remove the key from the
map, as its memory has been overwritten already and thus the key
lookup it will fail and we cannot delete it.

Fix this by only decrementing the refcount of the evictee after
we have removed it from our cache map. Add a test that caused a
segfault previous to that change.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When evicting cache entries, we first retrieve the object that is
to be evicted, delete the object and then finally delete the key
from the cache. In case where the cache eviction caused us to
free the cached object, though, its key will point to invalid
memory now when trying to remove it from the cache map. On my
system, this causes us to not properly remove the key from the
map, as its memory has been overwritten already and thus the key
lookup it will fail and we cannot delete it.

Fix this by only decrementing the refcount of the evictee after
we have removed it from our cache map. Add a test that caused a
segfault previous to that change.
</pre>
</div>
</content>
</entry>
<entry>
<title>NetBSD &lt; 7 doesn't have posix_fallocate</title>
<updated>2019-05-24T09:48:47+00:00</updated>
<author>
<name>Jacques Germishuys</name>
<email>jacques.germishuys@gmail.com</email>
</author>
<published>2019-05-24T09:48:47+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=d668820dc885669b7d87b08041fe5ff7cb396098'/>
<id>d668820dc885669b7d87b08041fe5ff7cb396098</id>
<content type='text'>
See: https://www.netbsd.org/changes/changes-7.0.html
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
See: https://www.netbsd.org/changes/changes-7.0.html
</pre>
</div>
</content>
</entry>
<entry>
<title>repository: fix garbage return value</title>
<updated>2019-05-23T08:49:44+00:00</updated>
<author>
<name>Erik Aigner</name>
<email>aigner.erik@gmail.com</email>
</author>
<published>2019-05-23T08:49:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=9cc904dae15d713aebd9becf83f42c9accb597a1'/>
<id>9cc904dae15d713aebd9becf83f42c9accb597a1</id>
<content type='text'>
error was never initialized and a garbage value returned on success.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
error was never initialized and a garbage value returned on success.</pre>
</div>
</content>
</entry>
</feed>
