<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/libgit2.git/src/win32, branch ethomson/gitstr</title>
<subtitle>github.com: libgit2/libgit2.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/'/>
<entry>
<title>str: introduce `git_str` for internal, `git_buf` is external</title>
<updated>2021-10-17T13:49:01+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-09-07T21:53:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=f0e693b18afbe1de37d7da5b5a8967b6c87d8e53'/>
<id>f0e693b18afbe1de37d7da5b5a8967b6c87d8e53</id>
<content type='text'>
libgit2 has two distinct requirements that were previously solved by
`git_buf`.  We require:

1. A general purpose string class that provides a number of utility APIs
   for manipulating data (eg, concatenating, truncating, etc).
2. A structure that we can use to return strings to callers that they
   can take ownership of.

By using a single class (`git_buf`) for both of these purposes, we have
confused the API to the point that refactorings are difficult and
reasoning about correctness is also difficult.

Move the utility class `git_buf` to be called `git_str`: this represents
its general purpose, as an internal string buffer class.  The name also
is an homage to Junio Hamano ("gitstr").

The public API remains `git_buf`, and has a much smaller footprint.  It
is generally only used as an "out" param with strict requirements that
follow the documentation.  (Exceptions exist for some legacy APIs to
avoid breaking callers unnecessarily.)

Utility functions exist to convert a user-specified `git_buf` to a
`git_str` so that we can call internal functions, then converting it
back again.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
libgit2 has two distinct requirements that were previously solved by
`git_buf`.  We require:

1. A general purpose string class that provides a number of utility APIs
   for manipulating data (eg, concatenating, truncating, etc).
2. A structure that we can use to return strings to callers that they
   can take ownership of.

By using a single class (`git_buf`) for both of these purposes, we have
confused the API to the point that refactorings are difficult and
reasoning about correctness is also difficult.

Move the utility class `git_buf` to be called `git_str`: this represents
its general purpose, as an internal string buffer class.  The name also
is an homage to Junio Hamano ("gitstr").

The public API remains `git_buf`, and has a much smaller footprint.  It
is generally only used as an "out" param with strict requirements that
follow the documentation.  (Exceptions exist for some legacy APIs to
avoid breaking callers unnecessarily.)

Utility functions exist to convert a user-specified `git_buf` to a
`git_str` so that we can call internal functions, then converting it
back again.
</pre>
</div>
</content>
</entry>
<entry>
<title>win32: posixify the output of p_getcwd</title>
<updated>2021-09-25T13:39:01+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-09-25T13:36:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=d6c7ca3ea99aa97d520d741dee2a8542cd0f2e38'/>
<id>d6c7ca3ea99aa97d520d741dee2a8542cd0f2e38</id>
<content type='text'>
Make p_getcwd match the rest of our win32 path handling semantics.

(This is currently only used in tests, which is why this disparity went
unnoticed.)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Make p_getcwd match the rest of our win32 path handling semantics.

(This is currently only used in tests, which is why this disparity went
unnoticed.)
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix coding style for pointer</title>
<updated>2021-09-09T17:49:04+00:00</updated>
<author>
<name>punkymaniac</name>
<email>punkymaniac@protonmail.ch</email>
</author>
<published>2021-09-09T17:49:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=379c46463cbdd73e04c5efc180309d4600e56624'/>
<id>379c46463cbdd73e04c5efc180309d4600e56624</id>
<content type='text'>
Make some syntax change to follow coding style.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Make some syntax change to follow coding style.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #6006 from boretrk/c11-warnings</title>
<updated>2021-08-25T18:11:03+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-08-25T18:11:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=c7a195a1c4da41317916141fa0cfd0aabfdecfff'/>
<id>c7a195a1c4da41317916141fa0cfd0aabfdecfff</id>
<content type='text'>
GCC C11 warnings</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
GCC C11 warnings</pre>
</div>
</content>
</entry>
<entry>
<title>win32: name the dummy union in GIT_REPARSE_DATA_BUFFER</title>
<updated>2021-08-25T17:15:34+00:00</updated>
<author>
<name>Peter Pettersson</name>
<email>boretrk@hotmail.com</email>
</author>
<published>2021-08-25T16:14:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=4bbe5e6ea6f2084c4153fb6205115bd43db0a300'/>
<id>4bbe5e6ea6f2084c4153fb6205115bd43db0a300</id>
<content type='text'>
Instead of buf-&gt;"typeofbuffer"ReparseBuffer the members will be
referenced with buf-&gt;ReparseBuffer."typeofbuffer"

https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/ntifs/ns-ntifs-_reparse_data_buffer?redirectedfrom=MSDN
calls the union DUMMYUNIONNAME but that looks a bit cluttered.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Instead of buf-&gt;"typeofbuffer"ReparseBuffer the members will be
referenced with buf-&gt;ReparseBuffer."typeofbuffer"

https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/ntifs/ns-ntifs-_reparse_data_buffer?redirectedfrom=MSDN
calls the union DUMMYUNIONNAME but that looks a bit cluttered.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #5802 from lhchavez/git-warn-unused-result</title>
<updated>2021-08-25T16:30:06+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2021-08-25T16:30:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=efc4e7e56a7b8a406e37ef7b6444996b9e377cc7'/>
<id>efc4e7e56a7b8a406e37ef7b6444996b9e377cc7</id>
<content type='text'>
Introduce GIT_WARN_UNUSED_RESULT</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Introduce GIT_WARN_UNUSED_RESULT</pre>
</div>
</content>
</entry>
<entry>
<title>Get Win32 builds to build</title>
<updated>2021-08-09T02:08:59+00:00</updated>
<author>
<name>lhchavez</name>
<email>lhchavez@lhchavez.com</email>
</author>
<published>2021-07-30T13:53:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=b060080e9f036ab45b86d5d37473a8ec49c29acf'/>
<id>b060080e9f036ab45b86d5d37473a8ec49c29acf</id>
<content type='text'>
Previously, the location of `GIT_WARN_UNUSED_RESULT` was causing it to
be included _after_ a bunch of other headers (namely `src/vector.h`),
which broke the build.

This change does two things:

* Moves the `GIT_WARN_UNUSED_RESULT` above most of the `$include`s in
  `src/common.h`.
* Stops including `vector.h` from `src/win32/path_w32.c` since the
  header itself does not use it.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Previously, the location of `GIT_WARN_UNUSED_RESULT` was causing it to
be included _after_ a bunch of other headers (namely `src/vector.h`),
which broke the build.

This change does two things:

* Moves the `GIT_WARN_UNUSED_RESULT` above most of the `$include`s in
  `src/common.h`.
* Stops including `vector.h` from `src/win32/path_w32.c` since the
  header itself does not use it.
</pre>
</div>
</content>
</entry>
<entry>
<title>tests: optional test for p_open() with empty path segments</title>
<updated>2021-08-08T11:26:24+00:00</updated>
<author>
<name>Peter Pettersson</name>
<email>boretrk@hotmail.com</email>
</author>
<published>2021-08-08T11:22:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=e96fc0283aea9afd02f64bdcb26613422e74dc3a'/>
<id>e96fc0283aea9afd02f64bdcb26613422e74dc3a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Convert long long constant specifiers to stdint macros</title>
<updated>2021-07-07T22:12:02+00:00</updated>
<author>
<name>Calvin Buckley</name>
<email>calvin@cmpct.info</email>
</author>
<published>2021-07-07T22:12:02+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=52505ab5a2f0235d73553b6e8ecaa45943d1efc6'/>
<id>52505ab5a2f0235d73553b6e8ecaa45943d1efc6</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Initial pass at using int64_t instead of long long</title>
<updated>2021-07-07T02:28:47+00:00</updated>
<author>
<name>Calvin Buckley</name>
<email>calvin@cmpct.info</email>
</author>
<published>2021-07-07T02:25:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=c1aca3fedaf2cfe6d9bc7f5dbf5828a872dd74e5'/>
<id>c1aca3fedaf2cfe6d9bc7f5dbf5828a872dd74e5</id>
<content type='text'>
Even on systems without C99 where long long and stdint are both
missing, we can shim stdint and point it to any compiler-specific
type (i.e long long, _int64, etc.).

Also next is constant suffixes and determining what needs to
include stdint.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Even on systems without C99 where long long and stdint are both
missing, we can shim stdint and point it to any compiler-specific
type (i.e long long, _int64, etc.).

Also next is constant suffixes and determining what needs to
include stdint.
</pre>
</div>
</content>
</entry>
</feed>
