delta/libgit2.git/src/sysdir.c, branch ethomson/oidarray_dispose

sysdir: use GIT_ASSERT

2020-11-27T11:09:21+00:00

runtime: move init/shutdown into the "runtime"

2020-10-11T19:13:04+00:00

Provide a mechanism for system components to register for initialization
and shutdown of the libgit2 runtime.

sysdir: fix formatting error message with NULL string

2020-09-18T09:03:32+00:00

When trying to the template dir, we pass in a `NULL` pointer for the
filename. That's perfectly fine, but if we're failing to find the
template directory then we'll creat an error message with the `NULL`
pointer passed in.

Fix the issue by setting different error messages based on whether the
filename is given or not. This even makes sense, as we're not searching
for a file in case we have no `name`, but for a directory. So the error
would've been misleading anyway.

sysdir: remove unused git_sysdir_get_str

2020-04-05T10:16:29+00:00

config: check if we are running in a sandboxed environment

2019-08-01T18:04:11+00:00

On macOS the $HOME environment variable returns the path to the sandbox container instead of the actual user $HOME for sandboxed apps. To get the correct path, we have to get it from the password file entry.

git_error: use new names in internal APIs and usage

2019-01-22T22:30:35+00:00

Move to the `git_error` name in the internal API for error-related
functions.

Convert usage of `git_buf_free` to new `git_buf_dispose`

2018-06-10T17:34:37+00:00

sysdir: do not use environment in setuid case

2018-02-02T07:48:26+00:00

In order to derive the location of some Git directories, we currently
use the environment variables $HOME and $XDG_CONFIG_HOME. This might
prove to be problematic whenever the binary is run with setuid, that is
when the effective user does not equal the real user. In case the
environment variables do not get sanitized by the caller, we thus might
end up using the real user's configuration when doing stuff as the
effective user.

The fix is to use the passwd entry's directory instead of $HOME in this
situation. As this might break scenarios where the user explicitly sets
$HOME to another path, this fix is only applied in case the effective
user does not equal the real user.

Make sure to always include "common.h" first

2017-07-03T08:51:48+00:00

Next to including several files, our "common.h" header also declares
various macros which are then used throughout the project. As such, we
have to make sure to always include this file first in all
implementation files. Otherwise, we might encounter problems or even
silent behavioural differences due to macros or defines not being
defined as they should be. So in fact, our header and implementation
files should make sure to always include "common.h" first.

This commit does so by establishing a common include pattern. Header
files inside of "src" will now always include "common.h" as its first
other file, separated by a newline from all the other includes to make
it stand out as special. There are two cases for the implementation
files. If they do have a matching header file, they will always include
this one first, leading to "common.h" being transitively included as
first file. If they do not have a matching header file, they instead
include "common.h" as first file themselves.

This fixes the outlined problems and will become our standard practice
for header and source files inside of the "src/" from now on.

Introduce `git_sysdir_expand_global_file`

2017-03-23T12:12:39+00:00

Provide a mechanism for callers to expand the full path of a file in the
global configuration directory (that is to say, the home directory) even
if the file doesn't necessarily exist.  This lets callers use their own
logic for building paths separate from handling file existence.