delta/libgit2.git/src/strmap.h, branch ethomson/proxy github.com: libgit2/libgit2.git map: remove `*map_free` macros 2017-03-20T08:01:18+00:00 Patrick Steinhardt ps@pks.im 2017-03-20T08:01:18+00:00 94af9155cf908f402e07408d900177280c2e90bb The `map_free` functions were not implemented as functions but instead as macros which also set the map to NULL. While this is most certainly sensible in most cases, we should prefer the more obvious behavior, namingly leaving the map pointer intact. Furthermore, this macro has been refactored incorrectly during the map-refactorings: the two statements are not actually grouped together by a `do { ... } while (0)` block, as it is required for macros to match the behavior of functions more closely. This has led to at least one subtle nesting error in `pack-objects.c`. The following code block ``` if (pb->object_ix) git_oidmap_free(pb->object_ix); ``` would be expanded to ``` if (pb->object_ix) git_oidmap__free(pb->object_ix); pb->object_ix = NULL; ``` which is not what one woudl expect. While it is not a bug here as it would simply become a no-op, the wrong implementation could lead to bugs in other occasions. Fix this by simply removing the macro altogether and replacing it with real function calls. This leaves the burden of setting the pointer to NULL afterwards to the caller, but this is actually expected and behaves like other `free` functions. 
The `map_free` functions were not implemented as functions but instead
as macros which also set the map to NULL. While this is most certainly
sensible in most cases, we should prefer the more obvious behavior,
namingly leaving the map pointer intact.

Furthermore, this macro has been refactored incorrectly during the
map-refactorings: the two statements are not actually grouped together
by a `do { ... } while (0)` block, as it is required for macros to
match the behavior of functions more closely. This has led to at least
one subtle nesting error in `pack-objects.c`. The following code block

```
    if (pb->object_ix)
        git_oidmap_free(pb->object_ix);
```

would be expanded to

```
    if (pb->object_ix)
        git_oidmap__free(pb->object_ix); pb->object_ix = NULL;
```

which is not what one woudl expect. While it is not a bug here as it
would simply become a no-op, the wrong implementation could lead to bugs
in other occasions.

Fix this by simply removing the macro altogether and replacing it with
real function calls. This leaves the burden of setting the pointer to
NULL afterwards to the caller, but this is actually expected and behaves
like other `free` functions.
strmap: remove GIT__USE_STRMAP macro 2017-02-17T10:41:06+00:00 Patrick Steinhardt ps@pks.im 2017-01-27T13:32:23+00:00 13c3bc9adf7c3e467c6d1a577859bf31d551022b 






strmap: convert macros to functions
2017-02-17T10:41:06+00:00

Patrick Steinhardt
ps@pks.im

2017-01-27T13:13:49+00:00

a13cfd2af2aa2f9be660fc1c789405b5188b904d












khash: avoid using macro magic to get return address
2017-02-17T10:41:06+00:00

Patrick Steinhardt
ps@pks.im

2017-01-27T13:20:24+00:00

73028af85c11bd947184a73c1e2d7902819695b2












khash: avoid using `kh_key`/`kh_val` as lvalue
2017-02-17T10:41:06+00:00

Patrick Steinhardt
ps@pks.im

2017-01-27T13:05:10+00:00

85d2748c6f75bd810c7376647c8ae32984b5e3bb












khash: avoid using `kh_put` directly
2017-02-17T10:41:06+00:00

Patrick Steinhardt
ps@pks.im

2017-01-25T14:31:12+00:00

f31cb45ad2ca46cc743dfadf5ac8b916cbe4ea9c












strmap: remove unused macro `git_strmap_insert2`
2017-02-17T10:41:06+00:00

Patrick Steinhardt
ps@pks.im

2017-01-25T13:12:13+00:00

bff9b7a5a33c9aa8468d233676aba5dbad37b8d6












Remove extra semicolon outside of a function
2015-02-15T20:07:05+00:00

Stefan Widgren
stefan.widgren@gmail.com

2015-02-15T20:07:05+00:00

c8e02b8776875e6372fc5eba8fc61c51f14f3392

Without this change, compiling with gcc and pedantic generates warning:
ISO C does not allow extra ‘;’ outside of a function.





Without this change, compiling with gcc and pedantic generates warning:
ISO C does not allow extra ‘;’ outside of a function.







Update `khash.h` to pull request 42
2015-02-13T03:54:48+00:00

Edward Thomson
ethomson@microsoft.com

2015-02-11T22:51:17+00:00

650e45f69124bd8b53ecefddeb214a82538ab2c1

https://github.com/attractivechaos/klib/pull/42/files introduces
`kreallocarray`.  Hook that up as our `git__reallocarray`.





https://github.com/attractivechaos/klib/pull/42/files introduces
`kreallocarray`.  Hook that up as our `git__reallocarray`.







Add diff threading tests and attr file cache locks
2014-04-17T21:43:45+00:00

Russell Belfer
rb@github.com

2014-02-11T22:45:37+00:00

40ed499039f887ebcb0b5badf0157519148398b8

This adds a basic test of doing simultaneous diffs on multiple
threads and adds basic locking for the attr file cache because
that was the immediate problem that arose from these tests.





This adds a basic test of doing simultaneous diffs on multiple
threads and adds basic locking for the attr file cache because
that was the immediate problem that arose from these tests.