delta/libgit2.git/src/stash.c, branch ethomson/callback_names github.com: libgit2/libgit2.git git_error: use new names in internal APIs and usage 2019-01-22T22:30:35+00:00 Edward Thomson ethomson@edwardthomson.com 2018-12-27T19:47:34+00:00 f673e232afe22eb865cdc915e55a2df6493f0fbb Move to the `git_error` name in the internal API for error-related functions. 
Move to the `git_error` name in the internal API for error-related
functions.
stash: use _an_ index not _the_ index 2018-06-29T13:54:27+00:00 Edward Thomson ethomson@edwardthomson.com 2018-02-18T23:55:56+00:00 4919e495ed257ee7528ac09aea1e4c12011c282c Don't manipulate the repository's index during stash; instead, manipulate a temporary index and check it out. This allows us to use the checkout mechanism to update the workdir and the repository's index, and allows checkout to use its common mechanisms to write data and handle errors. 
Don't manipulate the repository's index during stash; instead,
manipulate a temporary index and check it out.

This allows us to use the checkout mechanism to update the workdir and
the repository's index, and allows checkout to use its common mechanisms
to write data and handle errors.
Convert usage of `git_buf_free` to new `git_buf_dispose` 2018-06-10T17:34:37+00:00 Patrick Steinhardt ps@pks.im 2018-02-08T11:14:48+00:00 ecf4f33a4e327a91496f72816f9f02d923e5af05 






checkout: change default strategy to SAFE
2018-03-26T19:02:16+00:00

Etienne Samson
samson.etienne@gmail.com

2018-03-26T18:44:13+00:00

cdd0bc2f878cc169b0c879f95156d6c356be07ba

As per #4200, our default is quite surprising to users that expect checkout to just "do the thing".




As per #4200, our default is quite surprising to users that expect checkout to just "do the thing".






Make sure to always include "common.h" first
2017-07-03T08:51:48+00:00

Patrick Steinhardt
ps@pks.im

2017-06-30T11:39:01+00:00

0c7f49dd4316b332f30b4ea72a657bace41e1245

Next to including several files, our "common.h" header also declares
various macros which are then used throughout the project. As such, we
have to make sure to always include this file first in all
implementation files. Otherwise, we might encounter problems or even
silent behavioural differences due to macros or defines not being
defined as they should be. So in fact, our header and implementation
files should make sure to always include "common.h" first.

This commit does so by establishing a common include pattern. Header
files inside of "src" will now always include "common.h" as its first
other file, separated by a newline from all the other includes to make
it stand out as special. There are two cases for the implementation
files. If they do have a matching header file, they will always include
this one first, leading to "common.h" being transitively included as
first file. If they do not have a matching header file, they instead
include "common.h" as first file themselves.

This fixes the outlined problems and will become our standard practice
for header and source files inside of the "src/" from now on.





Next to including several files, our "common.h" header also declares
various macros which are then used throughout the project. As such, we
have to make sure to always include this file first in all
implementation files. Otherwise, we might encounter problems or even
silent behavioural differences due to macros or defines not being
defined as they should be. So in fact, our header and implementation
files should make sure to always include "common.h" first.

This commit does so by establishing a common include pattern. Header
files inside of "src" will now always include "common.h" as its first
other file, separated by a newline from all the other includes to make
it stand out as special. There are two cases for the implementation
files. If they do have a matching header file, they will always include
this one first, leading to "common.h" being transitively included as
first file. If they do not have a matching header file, they instead
include "common.h" as first file themselves.

This fixes the outlined problems and will become our standard practice
for header and source files inside of the "src/" from now on.







giterr_set: consistent error messages
2016-12-29T12:26:03+00:00

Edward Thomson
ethomson@github.com

2016-12-29T12:25:15+00:00

909d5494368a00809bc42f4780e86f4dd66e4422

Error messages should be sentence fragments, and therefore:

1. Should not begin with a capital letter,
2. Should not conclude with punctuation, and
3. Should not end a sentence and begin a new one





Error messages should be sentence fragments, and therefore:

1. Should not begin with a capital letter,
2. Should not conclude with punctuation, and
3. Should not end a sentence and begin a new one







git_diff_generated: abstract generated diffs
2016-05-26T18:01:08+00:00

Edward Thomson
ethomson@github.com

2016-04-19T19:12:18+00:00

9be638ecf0d64ec98b3fd16f2d983a86d1aca131












Horrible fix for #3173.
2016-02-11T22:41:34+00:00

Arthur Schreiber
schreiber.arthur@googlemail.com

2016-02-11T22:37:52+00:00

3679ebaef5436a662ad74819f6cbd2c1e76e6766












iterator: use an options struct instead of args
2015-08-28T22:39:47+00:00

Edward Thomson
ethomson@edwardthomson.com

2015-07-28T16:41:27+00:00

ed1c64464a4e3126eef5d74d2c14c19133fa9cd8












Fix #3094 - improve use of portable size_t/ssize_t format specifiers.
2015-07-12T17:55:19+00:00

Matthew Plough
matt.plough@gmail.com

2015-06-30T23:00:41+00:00

768f8be31c3fac1b0ed8f4d49cf7176a30586443

The header src/cc-compat.h defines portable format specifiers PRIuZ, PRIdZ, and PRIxZ. The original report highlighted the need to use these specifiers in examples/network/fetch.c.  For this commit, I checked all C source and header files not in deps/ and transitioned to the appropriate format specifier where appropriate.





The header src/cc-compat.h defines portable format specifiers PRIuZ, PRIdZ, and PRIxZ. The original report highlighted the need to use these specifiers in examples/network/fetch.c.  For this commit, I checked all C source and header files not in deps/ and transitioned to the appropriate format specifier where appropriate.