delta/libgit2.git/src/signature.c, branch peff/binary-search-do-while github.com: libgit2/libgit2.git signature: don't leave a dangling pointer to the strings on parse failure 2017-07-12T05:41:37+00:00 Carlos Martín Nieto cmn@dwim.me 2017-07-12T05:40:16+00:00 d1dbb3ae67c156093419157eaf2fc6b8281432b8 If the signature is invalid but we detect that after allocating the strings, we free them. We however leave that pointer dangling in the structure the caller gave us, which can lead to double-free. Set these pointers to `NULL` after freeing their memory to avoid this. 
If the signature is invalid but we detect that after allocating the strings, we
free them. We however leave that pointer dangling in the structure the caller
gave us, which can lead to double-free.

Set these pointers to `NULL` after freeing their memory to avoid this.
signature: free dup'd buffers on parse error 2017-05-01T21:55:12+00:00 Edward Thomson ethomson@edwardthomson.com 2017-05-01T20:32:24+00:00 34c131062412480abd87ab825c2cd6c1b691e5f5 






giterr_set: consistent error messages
2016-12-29T12:26:03+00:00

Edward Thomson
ethomson@github.com

2016-12-29T12:25:15+00:00

909d5494368a00809bc42f4780e86f4dd66e4422

Error messages should be sentence fragments, and therefore:

1. Should not begin with a capital letter,
2. Should not conclude with punctuation, and
3. Should not end a sentence and begin a new one





Error messages should be sentence fragments, and therefore:

1. Should not begin with a capital letter,
2. Should not conclude with punctuation, and
3. Should not end a sentence and begin a new one







Fix off-by-one problems in git_signature__parse
2016-12-17T16:40:49+00:00

Andreas Henriksson
andreas@fatal.se

2016-12-17T16:33:13+00:00

23c9ff8632d8ae90d211601d3254ab7f4d35e853

Etc/GMT-14 aka UTC+14:00 is a thing....
https://en.wikipedia.org/wiki/UTC%2B14:00

Also allow offsets on the last minute (59).

Addresses: https://bugs.debian.org/841532
Fixes: #3970





Etc/GMT-14 aka UTC+14:00 is a thing....
https://en.wikipedia.org/wiki/UTC%2B14:00

Also allow offsets on the last minute (59).

Addresses: https://bugs.debian.org/841532
Fixes: #3970







Introduce `git_signature_from_buffer`
2016-04-28T16:47:14+00:00

Edward Thomson
ethomson@github.com

2016-04-28T16:47:14+00:00

d383c39b3bc9a2bd5e68882db9a12e64ccd262a4

Allow users to construct a signature from the type of signature
lines that actually appear in commits.





Allow users to construct a signature from the type of signature
lines that actually appear in commits.







signature: use GITERR_CHECK_ALLOC to check for OOM situation
2016-02-18T19:50:33+00:00

Patrick Steinhardt
ps@pks.im

2016-02-15T10:30:48+00:00

038d7af08595eabaa3d23da4703f25f4517af365

When checking for out of memory situations we usually use the
GITERR_CHECK_ALLOC macro. Besides conforming to our current code
base it adds the benefit of silencing errors in Coverity due to
Coverity handling the macro's error path as abort.





When checking for out of memory situations we usually use the
GITERR_CHECK_ALLOC macro. Besides conforming to our current code
base it adds the benefit of silencing errors in Coverity due to
Coverity handling the macro's error path as abort.







signature: Strip crud just like Git does
2015-10-21T09:58:44+00:00

Vicent Marti
tanoku@gmail.com

2015-10-21T09:58:44+00:00

307c4a2b6d1e3b403225b3d5b7f9894b940b24bd












Introduce git_rebase_commit
2014-10-27T02:59:19+00:00

Edward Thomson
ethomson@edwardthomson.com

2014-07-17T22:25:03+00:00

a35a9890b00b538cd0f3ef94a526c0dd2ec461bf

Commit the current patch of a rebase process.





Commit the current patch of a rebase process.







signature: add a dup function which takes a pool
2014-09-30T13:44:32+00:00

Carlos Martín Nieto
cmn@dwim.me

2014-06-28T05:29:46+00:00

bdeb8772fe846eeeea92cb2d9adb85315f3b8417

This will be used by the transaction code.





This will be used by the transaction code.







signature: don't allow empty emails
2014-09-10T16:14:46+00:00

Carlos Martín Nieto
cmn@dwim.me

2014-09-10T16:13:34+00:00

76e3c43fb99eb75cf33affb1a93260af4d472da5

A signature is made up of a non-empty name and a non-empty email so
let's validate that. This also brings us more in line with git, which
also rejects ident with an empty email.





A signature is made up of a non-empty name and a non-empty email so
let's validate that. This also brings us more in line with git, which
also rejects ident with an empty email.