delta/libgit2.git/src/refdb.c, branch ethomson/object_size github.com: libgit2/libgit2.git git_error: use new names in internal APIs and usage 2019-01-22T22:30:35+00:00 Edward Thomson ethomson@edwardthomson.com 2018-12-27T19:47:34+00:00 f673e232afe22eb865cdc915e55a2df6493f0fbb Move to the `git_error` name in the internal API for error-related functions. 
Move to the `git_error` name in the internal API for error-related
functions.
Make sure to always include "common.h" first 2017-07-03T08:51:48+00:00 Patrick Steinhardt ps@pks.im 2017-06-30T11:39:01+00:00 0c7f49dd4316b332f30b4ea72a657bace41e1245 Next to including several files, our "common.h" header also declares various macros which are then used throughout the project. As such, we have to make sure to always include this file first in all implementation files. Otherwise, we might encounter problems or even silent behavioural differences due to macros or defines not being defined as they should be. So in fact, our header and implementation files should make sure to always include "common.h" first. This commit does so by establishing a common include pattern. Header files inside of "src" will now always include "common.h" as its first other file, separated by a newline from all the other includes to make it stand out as special. There are two cases for the implementation files. If they do have a matching header file, they will always include this one first, leading to "common.h" being transitively included as first file. If they do not have a matching header file, they instead include "common.h" as first file themselves. This fixes the outlined problems and will become our standard practice for header and source files inside of the "src/" from now on. 
Next to including several files, our "common.h" header also declares
various macros which are then used throughout the project. As such, we
have to make sure to always include this file first in all
implementation files. Otherwise, we might encounter problems or even
silent behavioural differences due to macros or defines not being
defined as they should be. So in fact, our header and implementation
files should make sure to always include "common.h" first.

This commit does so by establishing a common include pattern. Header
files inside of "src" will now always include "common.h" as its first
other file, separated by a newline from all the other includes to make
it stand out as special. There are two cases for the implementation
files. If they do have a matching header file, they will always include
this one first, leading to "common.h" being transitively included as
first file. If they do not have a matching header file, they instead
include "common.h" as first file themselves.

This fixes the outlined problems and will become our standard practice
for header and source files inside of the "src/" from now on.
giterr_set: consistent error messages 2016-12-29T12:26:03+00:00 Edward Thomson ethomson@github.com 2016-12-29T12:25:15+00:00 909d5494368a00809bc42f4780e86f4dd66e4422 Error messages should be sentence fragments, and therefore: 1. Should not begin with a capital letter, 2. Should not conclude with punctuation, and 3. Should not end a sentence and begin a new one 
Error messages should be sentence fragments, and therefore:

1. Should not begin with a capital letter,
2. Should not conclude with punctuation, and
3. Should not end a sentence and begin a new one
refdb: bubble up locked files on the read side 2016-11-14T10:35:38+00:00 Carlos Martín Nieto cmn@dwim.me 2016-03-10T21:01:09+00:00 ce5553d48b8ba3510dd5032dfbfd161fb801cd77 On Windows we can find locked files even when reading a reference or the packed-refs file. Bubble up the error in this case as well to allow callers on Windows to retry more intelligently. 
On Windows we can find locked files even when reading a reference or the
packed-refs file. Bubble up the error in this case as well to allow
callers on Windows to retry more intelligently.
refdb and odb backends must provide `free` function 2015-09-30T22:50:37+00:00 Arthur Schreiber schreiber.arthur@googlemail.com 2015-09-30T22:50:37+00:00 d3b29fb94bf1c1d0caec39b4a2c3d2061c63efec As refdb and odb backends can be allocated by client code, libgit2 can’t know whether an alternative memory allocator was used, and thus should not try to call `git__free` on those objects. Instead, odb and refdb backend implementations must always provide their own `free` functions to ensure memory gets freed correctly. 
As refdb and odb backends can be allocated by client code, libgit2
can’t know whether an alternative memory allocator was used, and thus
should not try to call `git__free` on those objects.

Instead, odb and refdb backend implementations must always provide
their own `free` functions to ensure memory gets freed correctly.
Introduce reference transactions 2014-09-30T13:44:32+00:00 Carlos Martín Nieto cmn@dwim.me 2014-06-28T04:39:38+00:00 ab8d9242f54e2c570f86a45a509b9420911a4d44 A transaction allows you to lock multiple references and set up changes for them before applying the changes all at once (or as close as the backend supports). This can be used for replication purposes, or for making sure some operations run when the reference is locked and thus cannot be changed. 
A transaction allows you to lock multiple references and set up changes
for them before applying the changes all at once (or as close as the
backend supports).

This can be used for replication purposes, or for making sure some
operations run when the reference is locked and thus cannot be changed.
Fix remaining init_options inconsistencies 2014-05-02T16:21:33+00:00 Russell Belfer rb@github.com 2014-04-30T18:16:31+00:00 bc91347b5894c98964a12c6637d5ca91d9723b42 There were a couple of "init_opts()" functions a few more cases of structure initialization that I somehow missed. 
There were a couple of "init_opts()" functions a few more cases
of structure initialization that I somehow missed.
Added function-based initializers for every options struct. 2014-03-06T02:49:23+00:00 Matthew Bowen matthew@mgbowen.com 2014-03-06T02:49:23+00:00 b9f819978c571cc806827e8b3ebc1a58a0755999 The basic structure of each function is courtesy of arrbee. 
The basic structure of each function is courtesy of arrbee.
refs: placeholder conditional delete 2014-02-05T11:07:57+00:00 Carlos Martín Nieto cmn@dwim.me 2014-02-05T10:07:34+00:00 7ee8c7e6776a3c5b3a45cfd10ccf205eebb3f3fe We don't actually pass the old value yet. 
We don't actually pass the old value yet.
refdb: add conditional symbolic updates 2014-02-05T11:07:56+00:00 Carlos Martín Nieto cmn@dwim.me 2014-02-04T21:04:00+00:00 911236619b5d774e33dd9f3de92a7c86c2befb26 Add a parameter to the backend to allow checking for the old symbolic target. 
Add a parameter to the backend to allow checking for the old symbolic
target.